Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version string to st2tests to make it installable #4982

Closed

Conversation

StephenWeber
Copy link

Prior to this change, this will fail:

cd st2tests/st2tests
pip install .

After this change that command successfully installs the st2tests package. This will also work for installing via GitHub as in:

pip install -e git+https://github.com/StackStorm/[email protected]#egg=st2tests&subdirectory=st2tests

The original request in #2574 is to get st2tests onto PyPI, and I'm not sure if this will accomplish that request, but this is a good first step.

@CLAassistant
Copy link

CLAassistant commented Jul 1, 2020

CLA assistant check
All committers have signed the CLA.

@StephenWeber
Copy link
Author

StephenWeber commented Jul 1, 2020

I see I need to sign the CLA, please wait while I seek approval to do so. In the meantime, I'm investigating the failure in Integration Tests, definitely seems like this somehow broke a test.

@StephenWeber
Copy link
Author

StephenWeber commented Jul 1, 2020

I'm blocked on running tests because of #3934 (I'm on OSX), though I might see if I can get enough installed to just run the st2tests integration tests.

@arm4b
Copy link
Member

arm4b commented Jul 1, 2020

You can also use Vagrant (https://github.com/stackstorm/st2vagrant) or Docker for development as StackStorm comes with lots of requirements and infra, including DB/MQ/etc.

@StephenWeber BTW, do you think it would be easier for you to sign DCO or CLA, considering your work environment?
We may switch to DCO soon.

@StephenWeber
Copy link
Author

Thanks for the tip on testing!

do you think it would be easier for you to sign DCO or CLA, considering your work environment?
We may switch to DCO soon.

We have an internal process for CLA, I do not believe we have a process for DCO but I can ask.

That said, my request is in with Legal and I expect an answer soon.

@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Jul 7, 2020
@StephenWeber
Copy link
Author

I heard back from legal, and they did say that a DCO would be easier - they prefer to sign company-level CLAs. I haven't gotten confirmation back that I can sign the individual CLA but I expect that to be approved this week.

In the meantime, I suppose I could also branch off of v3.2 and provide a similar PR for that in case a patch ever is released for that? My deployment is using v3.2 for the time being.

@StephenWeber
Copy link
Author

StephenWeber commented Jul 16, 2020

current Integration test error:

Python wrapper process script took more than 0.31 seconds to execute (0.3175). This most likely means
that a direct or in-direct import of a module which takes a long time to load has been added (e.g.
jsonschema, pecan, kombu, etc).`

I know I'm adding a new project import, and it's not over by much (0.0175 seconds) - unfortunately other tests that pass do not print out the actual value so I don't know how much import time I'm adding to the system with this change..

@StephenWeber
Copy link
Author

Integration tests failed to complete in time, closing and reopening ticket to trigger a new build.

@StephenWeber
Copy link
Author

Now the integration tests are back to failing for test_process_wrapper_exits_in_reasonable_timeframe, I'll see about running these locally... but I probably need help...

@stale
Copy link

stale bot commented Oct 19, 2020

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically marking is as stale. If this issue is not relevant or applicable anymore (problem has been fixed in a new version or similar), please close the issue or let us know so we can close it. On the contrary, if the issue is still relevant, there is nothing you need to do, but if you have any additional details or context which would help us when working on this issue, please include it as a comment to this issue.

@stale stale bot added the stale label Oct 19, 2020
@arm4b arm4b mentioned this pull request Dec 14, 2020
@arm4b arm4b closed this in #5104 Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS PR that changes 0-9 lines. Quick fix/merge. stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants