Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Remove explicit tokens #122

Merged
merged 4 commits into from
Nov 2, 2023
Merged

🔥 Remove explicit tokens #122

merged 4 commits into from
Nov 2, 2023

Conversation

flaxel
Copy link
Contributor

@flaxel flaxel commented Jun 2, 2023

Type of Change

  • Bugfix
  • Enhancement / new feature
  • Refactoring
  • Documentation

Description

  • remove explicit tokens
  • usage of one of the docker build secrets properties is recommended

Checklist

  • Add relevant labels (for example type of change or patch/minor/major)
  • Make sure not to introduce some mistakes
  • Update documentation
  • Review the Contributing Guideline and sign CLA
  • Reference relevant issue(s) and close them after merging

@flaxel flaxel added enhancement New feature or request major Pull requests with breakable changes labels Jun 2, 2023
@flaxel flaxel requested review from staust and timdittler June 2, 2023 09:42
@flaxel flaxel requested a review from a team as a code owner June 2, 2023 09:42
Copy link
Contributor

@timdittler timdittler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing a piece of advice on how to migrate from explicit tokens to docker build secrets. Would be great if not every team would have to figure this out by themselves.

@flaxel
Copy link
Contributor Author

flaxel commented Jun 26, 2023

@timdittler Yeah sure, but I would add this information directly to the release. I would write something like that:

Breaking Changes:
If you are using one of these variables ..., you need to adapt your workflow and move these variables to the parameter.

Is this okay? 🤔

@staust
Copy link
Contributor

staust commented Jun 26, 2023

I'm missing a piece of advice on how to migrate from explicit tokens to docker build secrets. Would be great if not every team would have to figure this out by themselves.

here is an example: https://github.com/Staffbase/play-store-connect-service/pull/92/files

@flaxel flaxel requested a review from staust October 31, 2023 17:30
@flaxel flaxel merged commit 2b64d39 into main Nov 2, 2023
2 checks passed
@flaxel flaxel deleted the removing-explicit-tokens branch November 2, 2023 15:32
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request major Pull requests with breakable changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants