Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add myself and bmb as CODEOWNERS for TestIO template #198

Merged
merged 3 commits into from
Nov 9, 2023
Merged

add myself and bmb as CODEOWNERS for TestIO template #198

merged 3 commits into from
Nov 9, 2023

Conversation

jreimone
Copy link
Contributor

@jreimone jreimone commented Nov 9, 2023

Type of Change

  • Bugfix
  • Enhancement / new feature
  • Refactoring
  • Documentation
  • CODEOWNERS

Description

I'd like to be added as reviewer when the TestIO workflow template is changed. What do the Workflow Enthusiasts think about that?

Checklist

  • Add relevant labels (for example type of change or patch/minor/major)
  • Make sure not to introduce some mistakes
  • Update documentation
  • Review the Contributing Guideline and sign CLA
  • Reference relevant issue(s) and close them after merging

@jreimone
add myself and bmb as CODEOWNERS for TestIO template
7cb2f00 
I'd like to be added as reviewer when the TestIO workflow template is changed
@jreimone jreimone added the patch Pull request with little updates label Nov 9, 2023
@jreimone jreimone requested a review from a team as a code owner November 9, 2023 08:58
timdittler
timdittler approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@timdittler timdittler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please align columns

@flaxel flaxel added the documentation Improvements or additions to documentation label Nov 9, 2023
flaxel
flaxel reviewed Nov 9, 2023
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
jreimone and others added 2 commits November 9, 2023 10:38
@jreimone jreimone merged commit a307429 into main Nov 9, 2023
2 checks passed
@jreimone jreimone deleted the testio-template-codeowners branch November 9, 2023 09:40
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flaxel flaxel flaxel left review comments

@timdittler timdittler timdittler approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation patch Pull request with little updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jreimone @flaxel @timdittler