🎨 Force automerge as admin #199
Conversation
flaxel
added
enhancement
| gh pr merge --auto --merge "$PR_URL" | ||
|
|
||
| if [ ${{ inputs.force }} == 'true' ]; then | ||
| gh pr merge "$PR_URL" --merge --admin |
There was a problem hiding this comment.
This will actually bypass all rules. Means also when another workflow fails it could lead to a merge. Or did I miss something?
There was a problem hiding this comment.
Yeah correct and that's the cause why I add two warnings. 🙌 But additionally you need to configure it in your repo so you can bypass any protection rules.
There was a problem hiding this comment.
TBH: I'm not happy with this. For example: I consider the warnings but decide to enable this feature. The next ten updates run totally fine. But a few months later this workflow will break the main branch of my repo, because of a breaking update. I might not notice this, because in the meantime I'm working on a different service.
I think the feature in its current implementation adds more risk than value.
There was a problem hiding this comment.
I guess this is an implementation detail how the repo owners use the workflow. I would recommend to use it as a last step of the pipeline,so the issue should never happen.🤔 We would use it f.e. in the alarm tool where we already have auch logic.
There was a problem hiding this comment.
Gotcha - let's get another review from @0x46616c6b, as I like to have his view on this.
flaxel
dismissed
axdotl’s stale review
talked about it and we can merge the PR
Type of Change
Description
Checklist