Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ Bump ubuntu image #285

Merged
merged 2 commits into from
Oct 22, 2024
Merged

⬆️ Bump ubuntu image #285

merged 2 commits into from
Oct 22, 2024

Conversation

flaxel
Copy link
Contributor

@flaxel flaxel commented Oct 14, 2024

Type of Change

  • Bugfix
  • Enhancement / new feature
  • Refactoring
  • Documentation

Description

  • bump ubuntu image version

Checklist

  • Add relevant labels (for example type of change or patch/minor/major)
  • Make sure not to introduce some mistakes
  • Update documentation
  • Review the Contributing Guideline and sign CLA
  • Reference relevant issue(s) and close them after merging

@flaxel flaxel added enhancement New feature or request major Pull requests with breakable changes labels Oct 14, 2024
@flaxel flaxel requested review from a team as code owners October 14, 2024 06:41
0x46616c6b
0x46616c6b approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@0x46616c6b 0x46616c6b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way we can test this change before releasing it? I'm not expecting problems, but if something occurs, the blast radius is huge.

@flaxel
Copy link
Contributor Author

flaxel commented Oct 17, 2024

@0x46616c6b We could use the branch name for some repositories to test it. 👀 But we already use this version in some repos and unit now we didn't occur any problems. Additionally with the bump I hope every developer tries it out on dev to check if the version works for the repository. 😆

@soemo
Copy link
Contributor

soemo commented Oct 17, 2024

We faced a problem in the backend during a bump to 24.04 - see thread

@flaxel
Copy link
Contributor Author

flaxel commented Oct 17, 2024 •
edited
Loading

This is correct but I also tested it with csvupload, auditlog, theming and scimmer and it works perfectly. 👀

@flaxel flaxel added dependencies Pull requests that update an action file and removed enhancement New feature or request labels Oct 18, 2024
@flaxel flaxel merged commit 8fd0321 into main Oct 22, 2024
7 checks passed
@flaxel flaxel deleted the MKT-000-bump-ubuntu-image branch October 22, 2024 14:24
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbmars sbmars sbmars approved these changes

@0x46616c6b 0x46616c6b 0x46616c6b approved these changes

@soemo soemo soemo approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update an action file major Pull requests with breakable changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flaxel @soemo @0x46616c6b @sbmars