Skip to content
This repository has been archived by the owner on May 28, 2021. It is now read-only.

[SDAO-213] Specification for testing #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sashasashasasha151
Copy link
Collaborator

No description provided.

Copy link

@gpevnev gpevnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good, but where is actual test specification (eg. steps you need to produce and result expectation)?

Comment on lines +87 to +88
install all with `npm install`. Then build and compile contracts with `npm run build` and
`npx oz compile`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIR this is not technically true. With npm run build you are building CLI (ts -> js) and npx oz compile is one which actually compiles contracts

12/24 length generated [here](https://iancoleman.io/bip39/).

After that run `npx oz accounts`. You will see all accounts with your mnemonic and the last step is
to ask money [here](https://goerli-faucet.slock.it/) for default account.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is default account? It is not very clear for me (and probably for other readers too (or I am just stupid))

Comment on lines +132 to +137
npx oz send-tx
? Pick a network goerli
? Pick an instance BlendToken at <BlendToken address from goerli>
? Select which function mint(beneficiary: address, amount: uint256)
? beneficiary: address: <first default address and then some seccond address>
? amount: uint256: <amount>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not bad, I didn't know that you can do something like this

* Each swap starts from secret and its hash. You can get them from
`./bin/staker-blend swap-generate`
* Ethereum lock timeout is hardcoded. So, to change it from one hour to your values you need to
change it in `./src/commands/swap/lock.ts` in `timeout` variable.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man, can't we pass it explicitly?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants