Fix access to UIWindow when delegate doesn't implement that property #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix access to UIWindow when delegate doesn't implement that property
♻️ Current situation & Problem
Currently, ResearchKit assumes that the
window
property is implemented by everyUIApplicationDelegate
. However, if you refer to the documentation of window the property is only required if you are using UIKit with Storyboard files. The automatic synthesis the documentation refers to doesn't seem to work according to our experience.This issue impacted, e.g., CS342/2024-PICS#43.
This PR fixes this issue by checking first, if the respective delegate instance responds to the window selector.
This PR also addresses an issue in the CI setup where artifact names where not unique and therefore failed the CI run.
⚙️ Release Notes
window
is not implemented for an UIApplicationDelegate.📚 Documentation
--
✅ Testing
This will be verified within #20. However, the PR requires to compiled ResearchKit xcfamework first.
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: