-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a multi-node concurrent memspeed test for GPU use case. #1185
Draft
artempriakhin
wants to merge
12
commits into
StanfordLegion:stable
Choose a base branch
from
artempriakhin:concurrent_memspeed
base: stable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add a multi-node concurrent memspeed test for GPU use case. #1185
artempriakhin
wants to merge
12
commits into
StanfordLegion:stable
from
artempriakhin:concurrent_memspeed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artempriakhin
commented
Feb 4, 2022
test/realm/concurrent_memspeed.cc
Outdated
Comment on lines
209
to
225
CopyProfResult result; | ||
result.copy_start_time = &memspeed_experiments[i].copy_start_time; | ||
result.copy_end_time = &memspeed_experiments[i].copy_end_time; | ||
result.copied_bytes = &memspeed_experiments[i].copied_bytes; | ||
result.total_copies = &memspeed_experiments[i].total_copies; | ||
result.done = UserEvent::create_user_event(); | ||
; | ||
ProfilingRequestSet prs; | ||
prs.add_request(p, COPYPROF_TASK, &result, sizeof(CopyProfResult)) | ||
.add_measurement<ProfilingMeasurements::OperationTimeline>() | ||
.add_measurement<ProfilingMeasurements::OperationMemoryUsage>(); | ||
profile_requests.push_back(prs); | ||
|
||
local_events.push_back(start); | ||
local_events.back() = | ||
copy_boundaries.copy(src_fields.back(), dst_fields.back(), | ||
profile_requests.back(), local_events.back()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is broken. Will either fix it or revert to the previous commit.
artempriakhin
force-pushed
the
concurrent_memspeed
branch
from
February 4, 2022 01:07
9323c46
to
eeb005e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.