Remove setupSimulators and cacheDerrivedData #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSchmiedmayer
requested changes
Jul 12, 2024
There was a problem hiding this comment.
Thank you for the deprecations @Supereg; I had one comment regarding a breaking change; would be great ot get your input on this before we merge the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove setupSimulators and cacheDerrivedData
♻️ Current situation & Problem
This PR removes the
setupSimulatorsandcacheDerrivedDatainputs to remove unused or unnecessary functionality.cacheDerrivedDatawas not used within the Spezi organization, therefore opted to just remove it.setupSimulatorsis still used in the TemplateApplication (PR is up to remove it), SpeziAccount and the Study App. Therefore, opted to print a deprecation notice and remove the script to save some build time.⚙️ Release Notes
cacheDerrivedDatainputsetupSimulatorsscript.📚 Documentation
Updated the description.
✅ Testing
--
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: