Remove access to application launch options via @Application on macOS #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippzagar
changed the title
Supereg
approved these changes
Feb 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
+ Coverage 84.78% 84.95% +0.18%
==========================================
Files 40 40
Lines 959 950 -9
==========================================
- Hits 813 807 -6
+ Misses 146 143 -3
Continue to review full report in Codecov by Sentry.
|
PSchmiedmayer
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove access to application launch options via @Application on macOS
♻️ Current situation & Problem
The current version of Spezi crashes when using the
ApplicationDelegateAdaptorwith the.spezi()view modifier on macOS platforms. This results from a broken assumption about the initialization order upon Spezi bootup on macOS (not Catalyst!): The.spezi()view modifier is evaluated (and thereforeSpeziinitialized) beforeSpeziAppDelegate/applicationWillFinishLaunching()is called.This currently leads to a
preconditionfailure on macOS withinSpeziAppDelegate/applicationWillFinishLaunching()asSpeziis already initialized.Background: We initialize
Spezion macOS within theSpeziAppDelegate/applicationWillFinishLaunching()so that the application launch options are accessible via@Application(@Application(\.launchOptions)).We noticed that error when lifting the SpeziSpeech module to visionOS & macOS: StanfordSpezi/SpeziSpeech#5
⚙️ Release Notes
📚 Documentation
Adjusted documentation in line about not supporting launch options on macOS anymore
✅ Testing
Manual testing
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: