Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to @_spi instead of @testable #101

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Mar 8, 2024

Migrate to @_spi instead of @testable

♻️ Current situation & Problem

Currently, we use @testable within XCTSpezi to access the internal interface of Spezi. This introduces complications for people using XCTSpezi. Using @_spi is also better as we have a reduced interface that we expose and even allow for others to leverage the same power when accessing the System Programming Interface.

⚙️ Release Notes

  • Fixed an issue where compilation fails in certain test environments.

📚 Documentation

--

✅ Testing

--

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg requested a review from PSchmiedmayer March 8, 2024 03:33
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good approach to me; we will need to adjust the Swift Package tests accordingly.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.97%. Comparing base (0ced3ef) to head (d698615).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   84.95%   84.97%   +0.02%     
==========================================
  Files          40       41       +1     
  Lines         950      951       +1     
==========================================
+ Hits          807      808       +1     
  Misses        143      143              
Files Coverage Δ
Sources/Spezi/Module/ModuleCollection.swift 100.00% <ø> (ø)
...pezi/Spezi/KnowledgeSources/LaunchOptionsKey.swift 100.00% <ø> (ø)
Sources/Spezi/Spezi/Spezi.swift 96.67% <100.00%> (ø)
Sources/Spezi/Standard/DefaultStandard.swift 100.00% <100.00%> (ø)
Sources/XCTSpezi/DependencyResolution.swift 94.45% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ced3ef...d698615. Read the comment docs.

@Supereg Supereg merged commit ce8b29f into main Mar 8, 2024
13 checks passed
@Supereg Supereg deleted the fix/use-spi-instead-of-testable branch March 8, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants