Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visibility of NotificationHandler default implementations and make Delegate methods open #102

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Mar 8, 2024

Fix visibility of NotificationHandler default implementations and make Delegate methods open

♻️ Current situation & Problem

The NotificationHandler provides empty default implementations but their implementation are not marked public. Therefore, they have no effect. Secondly, some SpeziAppDelegate methods are not declared as open. This reduces flexibility in certain cases where it might be helpful to inject custom logic or even just to debug some issues.

⚙️ Release Notes

  • Fixed default implementation of the NotificationHandler.
  • Make all SpeziAppDelegate methods open.

📚 Documentation

--

✅ Testing

--

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg requested a review from PSchmiedmayer March 8, 2024 18:02
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.97%. Comparing base (ce8b29f) to head (e32b690).

❗ Current head e32b690 differs from pull request most recent head 06b5dc4. Consider uploading reports for the commit 06b5dc4 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   84.97%   84.97%           
=======================================
  Files          41       41           
  Lines         951      951           
=======================================
  Hits          808      808           
  Misses        143      143           
Files Coverage Δ
Sources/Spezi/Spezi/SpeziAppDelegate.swift 90.91% <100.00%> (ø)
...pabilities/Notifications/NotificationHandler.swift 50.00% <50.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce8b29f...06b5dc4. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix!

@Supereg Supereg merged commit c43e4fa into main Mar 8, 2024
11 checks passed
@Supereg Supereg deleted the feature/default-visibility branch March 8, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants