Fix visibility of NotificationHandler default implementations and make Delegate methods open #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix visibility of NotificationHandler default implementations and make Delegate methods open
♻️ Current situation & Problem
The
NotificationHandler
provides empty default implementations but their implementation are not marked public. Therefore, they have no effect. Secondly, someSpeziAppDelegate
methods are not declared as open. This reduces flexibility in certain cases where it might be helpful to inject custom logic or even just to debug some issues.⚙️ Release Notes
SpeziAppDelegate
methods open.📚 Documentation
--
✅ Testing
--
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: