Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure @Dependency property and use BFS for DependencyManager #112

Merged
merged 18 commits into from
Aug 13, 2024

Be less strict about swiftlint upgrades

0847c72
Select commit
Loading
Failed to load commit list.
Merged

Restructure @Dependency property and use BFS for DependencyManager #112

Be less strict about swiftlint upgrades
0847c72
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 13, 2024 in 0s

90.33% (+2.30%) compared to d87e3d8

View this Pull Request on Codecov

90.33% (+2.30%) compared to d87e3d8

Details

Codecov Report

Attention: Patch coverage is 93.97590% with 15 lines in your changes missing coverage. Please review.

Project coverage is 90.33%. Comparing base (d87e3d8) to head (0847c72).

Files Patch % Lines
.../Spezi/Spezi/SpeziNotificationCenterDelegate.swift 0.00% 10 Missing ⚠️
Sources/Spezi/Dependencies/DependencyManager.swift 97.60% 3 Missing ⚠️
...pezi/Dependencies/Property/DependencyContext.swift 90.91% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   88.03%   90.33%   +2.30%     
==========================================
  Files          47       47              
  Lines        1470     1602     +132     
==========================================
+ Hits         1294     1447     +153     
+ Misses        176      155      -21     
Files Coverage Δ
...pezi/Capabilities/Lifecycle/LifecycleHandler.swift 88.89% <ø> (ø)
...pabilities/Notifications/NotificationHandler.swift 50.00% <ø> (ø)
...pabilities/ViewModifier/ViewModifierProvider.swift 94.45% <ø> (ø)
...pezi/Dependencies/Property/DependencyBuilder.swift 100.00% <100.00%> (ø)
...i/Dependencies/Property/DependencyCollection.swift 98.91% <100.00%> (+4.97%) ⬆️
...dencies/Property/DependencyCollectionBuilder.swift 40.00% <100.00%> (ø)
.../Dependencies/Property/DependencyDeclaration.swift 100.00% <ø> (ø)
...endencies/Property/DependencyPropertyWrapper.swift 93.94% <100.00%> (+1.26%) ⬆️
Sources/Spezi/Module/ModuleBuilder.swift 100.00% <ø> (ø)
Sources/Spezi/Spezi/Spezi.swift 98.88% <100.00%> (+0.82%) ⬆️
... and 4 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d87e3d8...0847c72. Read the comment docs.