-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforcement of customizable type constraints for DependencyBuilder #93
Conversation
Thanks a lot to @Supereg for helping with the design/implementation! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
+ Coverage 91.46% 91.53% +0.08%
==========================================
Files 30 31 +1
Lines 655 661 +6
==========================================
+ Hits 599 605 +6
Misses 56 56
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you already expect a review, but had a chance to look at the implementation and had a small comment. So I'm already submitting that now 👍
Looks great 🚀
Thanks for the review, didn't expect it so quickly as I wanted to write some additional test cases :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @philippzagar for the additions and thank you for @Supereg for the support! I added two smaller comments about docs but apart from this I am happy to see the PR being merged 👍
@PSchmiedmayer Please merge the PR, small testing check is failing as the result builder default protocol implementation leads to a few patch coverage misses. |
Enforcement of customizable type constraints for DependencyBuilder
♻️ Current situation & Problem
As of now, the
DependencyBuilder
aggregates multiple types conforming toModule
towards aDependencyCollection
. However, the type constraint of the DependencyBuilder currently only enables the enforcement of theModule
conformance, not the conformance to other, more specific types that may be useful for implementing a Domain Specific Language.⚙️ Release Notes
DependencyCollectionBuilder
protocol📚 Documentation
DocC docs added.
✅ Testing
--
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: