Support dynamic initialization of optional dependencies #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 91.20% 91.34% +0.14%
==========================================
Files 34 34
Lines 693 704 +11
==========================================
+ Hits 632 643 +11
Misses 61 61
Continue to review full report in Codecov by Sentry.
|
|
Would suggest tagging this as |
PSchmiedmayer
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support dynamic initialization of optional dependencies
♻️ Current situation & Problem
Optional dependencies are already supported by Spezi. However, they lack the ability to dynamically supply a default value. Currently, you can only declare an optional dependency and check if it was configured e.g. by the user. But it wasn't possible to provide a default value (e.g., behind some runtime check) yourself.
⚙️ Release Notes
📚 Documentation
Documentation was added and updated.
✅ Testing
Extensive testing was added for the new initializer, testing all possible combinations of initialization.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: