-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve how we persist the last manually disconnected device #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool; thank you!
I will take a look at the runner issues that we have in place as noted on Slack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Supereg Finally found the time at the runner issues and fixed them; all builds are passing now 🚀
Improve how we persist the last manually disconnected device
♻️ Current situation & Problem
The feature that prevents the last known device from getting reconnected currently doesn't work properly. This PR fixes that to ensure that the last manually disconnected device won't be automatically connected again.
With fully enabling Swift 6, we discovered that SwiftUI assumes that mutations are executed on the MainActor. Therefore, this PR needed to restructures how mutations are notified using Observation and all mutations are now shadowed on the MainActor for improved compatibility with SwiftUI.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: