Fix Conan Build - Consistent Repo Hash IDs #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that we were pushing the built binary through the `export_sources` step. This was getting hashed and causing the repo hashs for windows, linux and mac to all be different. This caused problems in distribution through artifactory because I would never get the appropriate binary.
|
Confirmed build on Linux is the same repo id. |
jwatson0
approved these changes
Dec 19, 2023
Agreed - that is where I want to get to. It will have to be for the next release though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the
conanfile.pyto get a consistent hash id on different platforms.Note also - that
git config core.autocrlf falsemight also be necessary on windows so that theconanfile.pydoes not haveCRLFline endings.I've added a script to help run the build on both linux/mac/windows.
I've confirmed that I get the same hash on mac and windows. I'll be checking linux shortly.