Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up a few bugs with Admin Freeze #29

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Fix up a few bugs with Admin Freeze #29

merged 1 commit into from
Jan 18, 2024

Conversation

blinkdog
Copy link
Collaborator

@blinkdog blinkdog commented Jan 13, 2024

About The Pull Request

This fixes up a few issues with the [Admin] Freeze verb:

  • Overlay effect is now added to and removed from frozen mobs
  • Fixed a typo in a closing tag that wasn't quite all the way closed
  • Changed the hardcoded layer value 4.1 to a defined layer constant ABOVE_ALL_MOB_LAYER

Fixes #28

Why It's Good For The Game

Other players can see admins are intervening with a particular player, and stay away.

Changelog

🆑
fix: Fixed a span tag missing a closing bracket
fix: Fixed admin freeze overlay not appearing on frozen mobs
refactor: Changed hardcoded layer value to defined layer constant
admin: Freeze or burn? Freezerburn!
/:cl:

@blinkdog blinkdog requested a review from lectronyx January 13, 2024 07:12
@blinkdog blinkdog self-assigned this Jan 13, 2024
@github-actions github-actions bot added the Code change Watch something violently break. label Jan 13, 2024
@blinkdog blinkdog merged commit 8cbbee3 into master Jan 18, 2024
12 checks passed
@blinkdog blinkdog deleted the admin-freezerburn branch January 18, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Overlay graphic is missing when characters are Admin Frozen
1 participant