Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from Shiptest on 2024-01-20 #31

Merged
merged 87 commits into from
Jan 20, 2024
Merged

Conversation

blinkdog
Copy link
Collaborator

About The Pull Request

Brings in the changes from Shiptest upstream until 2024-01-20

Why It's Good For The Game

Bug fixes and new features improve the codebase.

FalloutFalcon and others added 30 commits December 20, 2023 16:42
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

No longer will you have to see a massive fix me when you accidentally
create material tiles instead of the ones you actually wanted!

Fixes #2528

![image](https://github.com/shiptest-ss13/Shiptest/assets/86381784/86c19011-1f17-4129-a75c-de3b38ce130c)

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game

I would argue for scraping them entirely but that fix me sprite was
REALLY annoying me, We have had it for 2 years based on the commit
history
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
fix: Material tile sprites
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
…607)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Anomalies have a randomized research output, which is visible with
science goggles. To harvest this research, you have to signal the
anomaly, then put the core into your research console.

The core's research output was actually just randomized as well with the
same range as the anomaly, rather than being given its output, meaning
the expected output and actual output could be completely different

## Why It's Good For The Game

Science goggles won't lie to you when looking at anomalies

## Changelog

:cl:
fix: science goggles are now more accurate when judging the research
value of anomalies
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

Signed-off-by: Theos <[email protected]>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Adds a few missing iconstates to vox hardhats. 
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
As silly as it was to watch your local vox's head be consumed by The
Void whenever they wanted to see better, it wasn't very good for
immersion. Also, bugs bad, m'kay?
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
imageadd: Adds missing iconstates to vox hardhats. Taste the void no
longer!
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Fixes #2423
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
 
No one uses these but shouldnt have it defined twice in case someone
does :clueless4:
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

🆑
fix: Fixes two assistant outfits having the same path
/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
@thgvr 

![image](https://github.com/shiptest-ss13/Shiptest/assets/34109002/ae3c8e9f-bf0f-490a-851d-e7587c7fb1a8)
ok
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
fix bug
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
fix: crate shelves no longer have layering issues
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Changes info shown to shipowners abotu ship memos

## Changelog

:cl:
tweak: Changed the text shown to shipowners about making a memo.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Charliestation solars didn't get gravity as a solar subtype, they now
have it
2 tiles with space area have been fixed to their proper area, probably
caused some gravity goofiness too

## Why It's Good For The Game

fixes #769

## Changelog

:cl:
fix: the charliestation ruin on ice planets now obeys local gravity
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Removes a flora with an invalid varedited texture on Jungle_Paradise. 
Please don't varedit flora textures. Use the correct type or subtype it
and . ..() if one doesn't exist.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Missing textures on maps is bad and not good.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
fix: Removed a flora with a varedited error texture on jungle_paradise
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
changes up description and UI interactions of crate shelves. Mouse
cursor will now switch to a drag+drop cursor when clickdragging crates,
and the description is more descriptive. also changes spans to use the
cleaner span_blahblah() proc
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

🆑 
tweak: cursor will now switch to a clickdrag cursor when clickdragging
crates
tweak: crate shelf description improved
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Updates our TGS chat commands to use the new framework, and adds a few
more commands similar to our redbot's.

Also adds a feature where the round will automatically be delayed when a
TGS deployment is incoming.

## Why It's Good For The Game

Better access to commands for those who don't want to set up our
external redbot. Plus, it's nice to support the new features.

Also, delaying the round before a deploy certainly saves me a lot of
headaches from trying to squeeze in a deployment before round restart.

## Changelog

:cl:
admin: The server will now automatically delay round-end when a TGS
deployment is incoming
server: Adds more TGS chat commands as well as support for the newer
chat message system.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Removes the wildly inconsistent and unmaintained whitesands relic that
is the Lieutenant job (formerly known as the Solgov Representative. Yes,
that one). Pieces of its clothing were shoved into various ships or
outfits, and it was only ever used on the Shetland which is admittedly
very dated and in need of modernizing. This should not touch the LP
Lieutenant job or the Twinkleshine Lieutenant job.
The Shetland now has a First Officer instead of a Lieutenant, and now
has two separate lockers for the FO and Captain instead of just one for
the Lieutenant. That poor, poor captain, locker-less for so long..
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game

![image](https://github.com/shiptest-ss13/Shiptest/assets/95449138/d52b76b1-8821-41e6-94f3-b1d8cb997148)
This job has visible rust from its existence in the whitesands era and
tries and fails to fill in at what the First Officer job does better.
The independent captain/command resprite also broke its jumpsuit sprites
due to the type paths overlapping.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
del: Removes the Lieutenant job datum, locker and clothing
add: The Shetland now has a First Officer and lockers for both them and
the captain now
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

code pulled the blade out of the sheath before checking if it was viably
targetted meaning you could remove the blade without clearing the lock
on the sheath

## Why It's Good For The Game

fixes #2501

## Changelog

:cl:
fix: the weebstick is no longer held back from its true purpose if you
click on a tile you can't see
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

Signed-off-by: Theos <[email protected]>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Fixes the hos jacket not being visible then kills the varedited
syndicate jacket!
Fixes #2143
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game

The Syndicate captain vest has replaced this much better
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
del: Syndicate Jacket
fix: Hos Jacket Invisibility
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
The legion core implant now gives you a potent heal of all four damage
types (-100 brute -100 burn -50 tox -50 oxy) instead of a literal aheal.
It now also deals 10 clone damage as a drawback to organics/FBPS (IPCS
excluded because they cant use clone damage medicine).
Due to how adjustBruteLoss and adjustBurnLoss work, the implanted core
no longer heals mechanical bodyparts, making it mostly useless for IPCs
and FBPs only healing oxygen and toxin damage.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
1. Player accessible aheals are not good and encourage exploiting to
cure ailments or gain an advantage.
2. Synthetics could use self-surgery to implant legion cores on the go
for a safety net heal. While not necessarily bad, it was insanely
powerful as an aheal and negated the requirement of stabilizing the core
and getting another person to put it in you.
3. It had literally no drawbacks. A strong consumable healing ability is
cool, but it should come with a cost.

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
fix: legion core implanting no longer aheals you on use
add: legion core implant now just does a potent organic heal with minor
clone damage when used
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Signed-off-by: zevo <[email protected]>
Co-authored-by: Mark Suckerberg <[email protected]>
rye-rice and others added 17 commits January 12, 2024 19:04
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Various bugfixes related to guns. Fixes #603? maybe?

## Why It's Good For The Game

Less bugs are great for the game. Trust me

## Changelog

:cl: FleetingExpertise
fix: The 'phantom round' bug with guns has been fixed
fix: Ghosts can no longer toggle gun safety
fix: Bulldogs no longer destroy shotgun shells from existence
fix: Bows should no longer randomly break
fix: A lot of jank involving the E-40 has been fixed

/:cl:
Bumps [gitpython](https://github.com/gitpython-developers/GitPython)
from 3.1.37 to 3.1.41.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/gitpython-developers/GitPython/releases">gitpython's
releases</a>.</em></p>
<blockquote>
<h2>3.1.41 - fix Windows security issue</h2>
<p>The details about the Windows security issue <a
href="https://github.com/gitpython-developers/GitPython/security/advisories/GHSA-2mqj-m65w-jghx">can
be found in this advisory</a>.</p>
<p>Special thanks go to <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> who
reported the issue and fixed it in a single stroke, while being
responsible for an incredible amount of improvements that he contributed
over the last couple of months ❤️.</p>
<h2>What's Changed</h2>
<ul>
<li>Add <code>__all__</code> in git.exc by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1719">gitpython-developers/GitPython#1719</a></li>
<li>Set submodule update cadence to weekly by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1721">gitpython-developers/GitPython#1721</a></li>
<li>Never modify sys.path by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1720">gitpython-developers/GitPython#1720</a></li>
<li>Bump git/ext/gitdb from <code>8ec2390</code> to <code>ec58b7e</code>
by <a href="https://github.com/dependabot"><code>@​dependabot</code></a>
in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1722">gitpython-developers/GitPython#1722</a></li>
<li>Revise comments, docstrings, some messages, and a bit of code by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1725">gitpython-developers/GitPython#1725</a></li>
<li>Use zero-argument super() by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1726">gitpython-developers/GitPython#1726</a></li>
<li>Remove obsolete note in _iter_packed_refs by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1727">gitpython-developers/GitPython#1727</a></li>
<li>Reorganize test_util and make xfail marks precise by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1729">gitpython-developers/GitPython#1729</a></li>
<li>Clarify license and make module top comments more consistent by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1730">gitpython-developers/GitPython#1730</a></li>
<li>Deprecate compat.is_<!-- raw HTML omitted -->, rewriting all uses by
<a href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in
<a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1732">gitpython-developers/GitPython#1732</a></li>
<li>Revise and restore some module docstrings by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1735">gitpython-developers/GitPython#1735</a></li>
<li>Make the rmtree callback Windows-only by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1739">gitpython-developers/GitPython#1739</a></li>
<li>List all non-passing tests in test summaries by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1740">gitpython-developers/GitPython#1740</a></li>
<li>Document some minor subtleties in test_util.py by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1749">gitpython-developers/GitPython#1749</a></li>
<li>Always read metadata files as UTF-8 in setup.py by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1748">gitpython-developers/GitPython#1748</a></li>
<li>Test native Windows on CI by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1745">gitpython-developers/GitPython#1745</a></li>
<li>Test macOS on CI by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1752">gitpython-developers/GitPython#1752</a></li>
<li>Let close_fds be True on all platforms by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1753">gitpython-developers/GitPython#1753</a></li>
<li>Fix IndexFile.from_tree on Windows by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1751">gitpython-developers/GitPython#1751</a></li>
<li>Remove unused TASKKILL fallback in AutoInterrupt by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1754">gitpython-developers/GitPython#1754</a></li>
<li>Don't return with operand when conceptually void by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1755">gitpython-developers/GitPython#1755</a></li>
<li>Group .gitignore entries by purpose by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1758">gitpython-developers/GitPython#1758</a></li>
<li>Adding dubious ownership handling by <a
href="https://github.com/marioaag"><code>@​marioaag</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1746">gitpython-developers/GitPython#1746</a></li>
<li>Avoid brittle assumptions about preexisting temporary files in tests
by <a href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a>
in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1759">gitpython-developers/GitPython#1759</a></li>
<li>Overhaul noqa directives by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1760">gitpython-developers/GitPython#1760</a></li>
<li>Clarify some Git.execute kill_after_timeout limitations by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1761">gitpython-developers/GitPython#1761</a></li>
<li>Bump actions/setup-python from 4 to 5 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1763">gitpython-developers/GitPython#1763</a></li>
<li>Don't install black on Cygwin by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1766">gitpython-developers/GitPython#1766</a></li>
<li>Extract all &quot;import gc&quot; to module level by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1765">gitpython-developers/GitPython#1765</a></li>
<li>Extract remaining local &quot;import gc&quot; to module level by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1768">gitpython-developers/GitPython#1768</a></li>
<li>Replace xfail with gc.collect in TestSubmodule.test_rename by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1767">gitpython-developers/GitPython#1767</a></li>
<li>Enable CodeQL by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1769">gitpython-developers/GitPython#1769</a></li>
<li>Replace some uses of the deprecated mktemp function by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1770">gitpython-developers/GitPython#1770</a></li>
<li>Bump github/codeql-action from 2 to 3 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1773">gitpython-developers/GitPython#1773</a></li>
<li>Run some Windows environment variable tests only on Windows by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1774">gitpython-developers/GitPython#1774</a></li>
<li>Fix TemporaryFileSwap regression where file_path could not be Path
by <a href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a>
in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1776">gitpython-developers/GitPython#1776</a></li>
<li>Improve hooks tests by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1777">gitpython-developers/GitPython#1777</a></li>
<li>Fix if items of Index is of type PathLike by <a
href="https://github.com/stegm"><code>@​stegm</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1778">gitpython-developers/GitPython#1778</a></li>
<li>Better document IterableObj.iter_items and improve some subclasses
by <a href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a>
in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1780">gitpython-developers/GitPython#1780</a></li>
<li>Revert &quot;Don't install black on Cygwin&quot; by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1783">gitpython-developers/GitPython#1783</a></li>
<li>Add missing pip in $PATH on Cygwin CI by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1784">gitpython-developers/GitPython#1784</a></li>
<li>Shorten Iterable docstrings and put IterableObj first by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1785">gitpython-developers/GitPython#1785</a></li>
<li>Fix incompletely revised Iterable/IterableObj docstrings by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1786">gitpython-developers/GitPython#1786</a></li>
<li>Pre-deprecate setting Git.USE_SHELL by <a
href="https://github.com/EliahKagan"><code>@​EliahKagan</code></a> in <a
href="https://redirect.github.com/gitpython-developers/GitPython/pull/1782">gitpython-developers/GitPython#1782</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/gitpython-developers/GitPython/commit/f28873828496a6632b3a99101e3582ad164e9bb9"><code>f288738</code></a>
bump patch level</li>
<li><a
href="https://github.com/gitpython-developers/GitPython/commit/ef3192cc414f2fd9978908454f6fd95243784c7f"><code>ef3192c</code></a>
Merge pull request <a
href="https://redirect.github.com/gitpython-developers/GitPython/issues/1792">#1792</a>
from EliahKagan/popen</li>
<li><a
href="https://github.com/gitpython-developers/GitPython/commit/1f3caa31f1b63908235e341418a0804ed37a320a"><code>1f3caa3</code></a>
Further clarify comment in test_hook_uses_shell_not_from_cwd</li>
<li><a
href="https://github.com/gitpython-developers/GitPython/commit/3eb7c2ab82e6dbe101ff916fca29d539cc2793af"><code>3eb7c2a</code></a>
Move safer_popen from git.util to git.cmd</li>
<li><a
href="https://github.com/gitpython-developers/GitPython/commit/c551e916c7b9e2d623b9d76f3352849a707d9bbe"><code>c551e91</code></a>
Extract shared logic for using Popen safely on Windows</li>
<li><a
href="https://github.com/gitpython-developers/GitPython/commit/15ebb258d4eebd9bf0f38780570d57e0b968b8de"><code>15ebb25</code></a>
Clarify comment in test_hook_uses_shell_not_from_cwd</li>
<li><a
href="https://github.com/gitpython-developers/GitPython/commit/f44524a9a9c8122b9b98d6e5797e1dfc3211c0b7"><code>f44524a</code></a>
Avoid spurious &quot;location may have moved&quot; on Windows</li>
<li><a
href="https://github.com/gitpython-developers/GitPython/commit/a42ea0a38c489caf9969836141120d760d3754b4"><code>a42ea0a</code></a>
Cover absent/no-distro bash.exe in hooks &quot;not from cwd&quot;
test</li>
<li><a
href="https://github.com/gitpython-developers/GitPython/commit/7751436b94d96ce0978b301681b851edd6efed63"><code>7751436</code></a>
Extract venv management from test_installation</li>
<li><a
href="https://github.com/gitpython-developers/GitPython/commit/66ff4c177accfb4f21d3eb476381d248d99fd8b5"><code>66ff4c1</code></a>
Omit CWD in search for bash.exe to run hooks on Windows</li>
<li>Additional commits viewable in <a
href="https://github.com/gitpython-developers/GitPython/compare/3.1.37...3.1.41">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=gitpython&package-manager=pip&previous-version=3.1.37&new-version=3.1.41)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/shiptest-ss13/Shiptest/network/alerts).

</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
## About The Pull Request

changes the behavior downstream of /datum/map_template's
should_place_on_top (the particular proc in question is
build_coordinate, and its placeOnTop variable) so that, when false, the
baseturfs of the resulting turf are set to the baseturfs of the type
being placed, instead of the previous behavior, which preserved the old
baseturfs entirely.

this odd behavior seemed to be specialized for holodecks, and i
mistakenly assumed it'd work for outposts given the variable name and an
experiment on a testing map. the behavior has been changed to alter the
baseturfs according to the type (so that placing a template with
should_place_on_top = FALSE results in the same baseturfs list as you'd
get from a changeturf(type, initial(type.baseturfs) call), so that
outposts should now place with the correct baseturfs. this enables
planetary outposts with a special baseturf defined in a ztrait; before,
they would be stuck with a space turf hiding in the baseturf list,
making their baseturfs basically always broken.

in order to accommodate this change without breaking holodeck code,
holodeck code has been largely removed, with a few exceptions where it'd
be a slight pain to remove certain turfs / objects that were originally
used in holodecks but which had been since used in other maps. there's
also a bit of admin functionality upstream of some holodeck procs that i
didn't want to touch

## Why It's Good For The Game

outposts spacing themselves when people pry up tiles is bad, and a fix
like this is necessary for planetary outposts to ever have the right
baseturfs.

## Changelog

:cl:
del: Holodeck code has been removed.
fix: Outposts should end up erroneously spaced less frequently.
/:cl:
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

it bugged me how bad the "randomisation" was so I just redid it all
properly with an md5

## Why It's Good For The Game

more diverse autowiki crew images

## Changelog

:cl:
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
…SecHud Icons (#2628)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
This pull request does the following:
* Revives shiptest-ss13/Shiptest#2455 and
shiptest-ss13/Shiptest#2493
* Sorts every factional outfit into a base outfit. These base outfits
apply a faction.
* Puts factional outfits into their own files.
* Adds (partial) factional backgrounds for sechud icons.

![imagen](https://github.com/shiptest-ss13/Shiptest/assets/75212565/07f7b83b-14bb-4cbf-a250-4dd16208da02)

![imagen](https://github.com/shiptest-ss13/Shiptest/assets/75212565/b32620e5-d0fe-4b59-b013-d30211f2f2aa)
* Adds a new Frontiersmen ERT. The gimmick is that their equipment is
randomized, for the true "when the first is killed, the second takes the
rifle" experience. You could get a mounted machine gun. Or a flyswatter.

![imagen](https://github.com/shiptest-ss13/Shiptest/assets/75212565/f5f058f1-4bdf-4abd-8bef-ff6158bdfb41)
* Makes Agent Cards work with SecHuds, and get overlays when using the
Select Chameleon Outfit button.
* Fixes the chameleon mask and goggles default icon states.

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Easier to sift through. IFF (2234). Support for custom SecHud icons.
Actually looks pretty on the outfit manager. Sugarcube Frontiersmen
Rogue-like 2024. Identity Threat+.

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl: MeeMOfCourse, retlaw34
tweak: Repathed almost every faction outfit, and they now apply factions
upon being used.
tweak: SecHud icons have been redone. Sprites by retlaw34.
tweak: Descriptions of multiple clothing items.
add: SecHuds now identify factions. Somewhat.
add: More desperate groups of Frontiersmen have been spotted roaming the
frontier.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Signed-off-by: meem <[email protected]>
This pull request updates the TGS DMAPI to the latest version. Please
note any breaking or unimplemented changes before merging.

Co-authored-by: github-actions <[email protected]>
… of damage (#2646)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request


![image](https://github.com/shiptest-ss13/Shiptest/assets/24857008/2e267cd6-7b43-4900-8a20-09e3b8879d30)


![image](https://github.com/shiptest-ss13/Shiptest/assets/24857008/75dad61e-84ac-4bd3-b285-a37e43a49d41)


## Why It's Good For The Game

Prevents a tend wounds heal cycle from targeting a limb that won't
benefit from its flat healing bonus.

## Changelog

:cl:
tweak: tend brute/burns can no longer attempt to (very ineffectively)
heal the other damage type
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

Signed-off-by: Theos <[email protected]>
@blinkdog blinkdog requested a review from lectronyx January 20, 2024 21:01
@blinkdog blinkdog self-assigned this Jan 20, 2024
@github-actions github-actions bot added Code change Watch something violently break. Dependencies DME Edit GitHub Our very own Babylon. Map Change Tile placing is hard. Thank you for your service. Sound USSR Anthem 2.66 MB file. Sprites A bikeshed full of soulless bikes. TGUI labels Jan 20, 2024
@blinkdog blinkdog merged commit 619d3ff into master Jan 20, 2024
12 of 13 checks passed
@blinkdog blinkdog deleted the upstream-update-20240120 branch January 20, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Dependencies DME Edit GitHub Our very own Babylon. Map Change Tile placing is hard. Thank you for your service. Sound USSR Anthem 2.66 MB file. Sprites A bikeshed full of soulless bikes. TGUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.