Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable FULL_INIT #32

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Enable FULL_INIT #32

merged 1 commit into from
Jan 23, 2024

Conversation

blinkdog
Copy link
Collaborator

@blinkdog blinkdog commented Jan 23, 2024

About The Pull Request

Enables the flag FULL_INIT because it will load CentCom and is very important for running fast in production.

Why It's Good For The Game

Load all the the CentCom things and run fast in production.

Changelog

🆑
tweak: Enabled FULL_INIT flag
/:cl:

@blinkdog blinkdog requested a review from lectronyx January 23, 2024 02:36
@blinkdog blinkdog self-assigned this Jan 23, 2024
@github-actions github-actions bot added Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. labels Jan 23, 2024
@blinkdog
Copy link
Collaborator Author

According to the CI stuff, it looks like CentCom map has some errors:

Error: Mapping error: Unconnected connector port located at CentCom Transport Shuttle Dock (estimated location: [153,87])
Error: Mapping error: Unconnected air vent located at CentCom Transport Shuttle Dock (estimated location: [150,86])
Error: Mapping error: Unconnected air vent located at CentCom Transport Shuttle Dock (estimated location: [154,87])
Error: Mapping error: Unconnected air vent located at CentCom Transport Shuttle Dock (estimated location: [145,88])
Error: Mapping error: Unconnected air vent located at CentCom Transport Shuttle Dock (estimated location: [158,88])
Error: Mapping error: Unconnected air vent located at CentCom Transport Shuttle Dock (estimated location: [151,92])
Error: Mapping error: Unconnected air vent located at CentCom Transport Shuttle Dock (estimated location: [144,93])
Error: Mapping error: Unconnected air vent located at CentCom Transport Shuttle Dock (estimated location: [154,94])
Error: Mapping error: Unconnected air vent located at CentCom Transport Shuttle Dock (estimated location: [149,98])
FAIL: /datum/unit_test/ship_outpost_placement 689.8s
	REASON #1: Mapping error: Unconnected connector port located at CentCom Transport Shuttle Dock (estimated location: [153,87]) at code/modules/unit_tests/ship_outpost_placement.dm:40
	REASON #2: Mapping error: Unconnected air vent located at CentCom Transport Shuttle Dock (estimated location: [150,86]) at code/modules/unit_tests/ship_outpost_placement.dm:40
	REASON #3: Mapping error: Unconnected air vent located at CentCom Transport Shuttle Dock (estimated location: [154,87]) at code/modules/unit_tests/ship_outpost_placement.dm:40
	REASON #4: Mapping error: Unconnected air vent located at CentCom Transport Shuttle Dock (estimated location: [145,88]) at code/modules/unit_tests/ship_outpost_placement.dm:40
	REASON #5: Mapping error: Unconnected air vent located at CentCom Transport Shuttle Dock (estimated location: [158,88]) at code/modules/unit_tests/ship_outpost_placement.dm:40
	REASON #6: Mapping error: Unconnected air vent located at CentCom Transport Shuttle Dock (estimated location: [151,92]) at code/modules/unit_tests/ship_outpost_placement.dm:40
	REASON #7: Mapping error: Unconnected air vent located at CentCom Transport Shuttle Dock (estimated location: [144,93]) at code/modules/unit_tests/ship_outpost_placement.dm:40
	REASON #8: Mapping error: Unconnected air vent located at CentCom Transport Shuttle Dock (estimated location: [154,94]) at code/modules/unit_tests/ship_outpost_placement.dm:40
	REASON #9: Mapping error: Unconnected air vent located at CentCom Transport Shuttle Dock (estimated location: [149,98]) at code/modules/unit_tests/ship_outpost_placement.dm:40

@blinkdog
Copy link
Collaborator Author

As mentioned in the comment, loading planets was disabled in:
https://github.com/Starfly-13/STARFLY-13/blob/master/code/modules/overmap/objects/dynamic_datum.dm#L152

@lectronyx
Copy link
Contributor

So this fixes runtimes and enables admin jail?

@lectronyx
Copy link
Contributor

Yeah, this is just enabling centcomm. Adds spawners for a bunch of antag roles we don't really use, but that just fixes errors so whatever lol

admin jail is good tho

@lectronyx lectronyx merged commit 2fa97b2 into master Jan 23, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants