-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rexml from 3.3.8 to 3.3.9 #681
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [rexml](https://github.com/ruby/rexml) from 3.3.8 to 3.3.9. - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.3.8...v3.3.9) --- updated-dependencies: - dependency-name: rexml dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
gem compare rexml 3.3.8 3.3.9 Compared versions: ["3.3.8", "3.3.9"]
DIFFERENT date:
3.3.8: 2024-09-29 00:00:00 UTC
3.3.9: 2024-10-24 00:00:00 UTC
DIFFERENT metadata:
3.3.8: {"changelog_uri"=>"https://github.com/ruby/rexml/releases/tag/v3.3.8"}
3.3.9: {"changelog_uri"=>"https://github.com/ruby/rexml/releases/tag/v3.3.9"}
DIFFERENT version:
3.3.8: 3.3.8
3.3.9: 3.3.9
DIFFERENT files:
3.3.8->3.3.9:
* Changed:
NEWS.md +21/-0
lib/rexml/parsers/baseparser.rb +8/-3
lib/rexml/rexml.rb +1/-1
lib/rexml/source.rb +8/-2
DIFFERENT extra_rdoc_files:
3.3.8->3.3.9:
* Changed:
NEWS.md +21/-0 |
gem compare --diff rexml 3.3.8 3.3.9 Compared versions: ["3.3.8", "3.3.9"]
DIFFERENT files:
3.3.8->3.3.9:
* Changed:
NEWS.md
--- /tmp/d20241028-1935-fgr0wx/rexml-3.3.8/NEWS.md 2024-10-28 19:09:59.890485825 +0000
+++ /tmp/d20241028-1935-fgr0wx/rexml-3.3.9/NEWS.md 2024-10-28 19:09:59.902485861 +0000
@@ -2,0 +3,21 @@
+## 3.3.9 - 2024-10-24 {#version-3-3-9}
+
+### Improvements
+
+ * Improved performance.
+ * GH-210
+ * Patch by NAITOH Jun.
+
+### Fixes
+
+ * Fixed a parse bug for text only invalid XML.
+ * GH-215
+ * Patch by NAITOH Jun.
+
+ * Fixed a parse bug that `�x...;` is accepted as a character
+ reference.
+
+### Thanks
+
+ * NAITOH Jun
+
lib/rexml/parsers/baseparser.rb
--- /tmp/d20241028-1935-fgr0wx/rexml-3.3.8/lib/rexml/parsers/baseparser.rb 2024-10-28 19:09:59.898485849 +0000
+++ /tmp/d20241028-1935-fgr0wx/rexml-3.3.9/lib/rexml/parsers/baseparser.rb 2024-10-28 19:09:59.910485885 +0000
@@ -153 +153 @@
- CHARACTER_REFERENCES = /�*((?:\d+)|(?:x[a-fA-F0-9]+));/
+ CHARACTER_REFERENCES = /&#((?:\d+)|(?:x[a-fA-F0-9]+));/
@@ -169,0 +170 @@
+ @source.ensure_buffer
@@ -572,2 +573,6 @@
- m = "0#{m}" if m[0] == ?x
- [Integer(m)].pack('U*')
+ if m.start_with?("x")
+ code_point = Integer(m[1..-1], 16)
+ else
+ code_point = Integer(m, 10)
+ end
+ [code_point].pack('U*')
lib/rexml/rexml.rb
--- /tmp/d20241028-1935-fgr0wx/rexml-3.3.8/lib/rexml/rexml.rb 2024-10-28 19:09:59.898485849 +0000
+++ /tmp/d20241028-1935-fgr0wx/rexml-3.3.9/lib/rexml/rexml.rb 2024-10-28 19:09:59.910485885 +0000
@@ -34 +34 @@
- VERSION = "3.3.8"
+ VERSION = "3.3.9"
lib/rexml/source.rb
--- /tmp/d20241028-1935-fgr0wx/rexml-3.3.8/lib/rexml/source.rb 2024-10-28 19:09:59.898485849 +0000
+++ /tmp/d20241028-1935-fgr0wx/rexml-3.3.9/lib/rexml/source.rb 2024-10-28 19:09:59.910485885 +0000
@@ -79,0 +80 @@
+ @term_encord = {}
@@ -230 +231 @@
- term = encode(term)
+ term = @term_encord[term] ||= encode(term)
@@ -297 +297,0 @@
- str = @source.readline(term || @line_break)
@@ -298,0 +299,4 @@
+ begin
+ str = @source.readline(term || @line_break)
+ rescue IOError
+ end
@@ -304,0 +309,2 @@
+ else
+ str = @source.readline(term || @line_break) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rexml from 3.3.8 to 3.3.9.
Release notes
Sourced from rexml's releases.
Changelog
Sourced from rexml's changelog.
Commits
38eaa86
Add 3.3.9 entryce59f2e
parser: fix a bug that �x...; is accepted as a character referencea09646d
test: fix indentcf0fb9c
FixIOSource#readline
for@pending_buffer
(#215)1d0c362
OptimizeIOSource#read_until
method (#210)622011f
Bump versionDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.