Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Development dockerfile database access #66

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

gbdlin
Copy link
Contributor

@gbdlin gbdlin commented Aug 12, 2024

  • Development dockerfile now contains DB access string.
  • Plugin container now relies on db container.
  • DB now uses named volume for storage instead of bind mount.

@gbdlin gbdlin force-pushed the fix/dev-docker-fixes branch from eb6424a to 8687122 Compare August 12, 2024 20:46
@TrainDoctor TrainDoctor added the enhancement New feature or request label Aug 12, 2024
@TrainDoctor TrainDoctor requested a review from a team August 12, 2024 22:02
Base automatically changed from fix/backblaze-auth-header to main August 13, 2024 00:11
- Development dockerfile now contains DB access string.
- Plugin container now relies on db container.
- DB now uses named volume for storage instead of bind mount.
- Postgresql DB for dev uses healthcheck to delay start of the app
  container.
@gbdlin gbdlin force-pushed the fix/dev-docker-fixes branch from 8687122 to baa7190 Compare August 13, 2024 01:09
@gbdlin gbdlin merged commit de2e3f3 into main Aug 14, 2024
7 checks passed
@gbdlin gbdlin deleted the fix/dev-docker-fixes branch August 14, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🔖 Ready for review
Development

Successfully merging this pull request may close these issues.

2 participants