Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative edition: Better cardarea support #214

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

betmma
Copy link

@betmma betmma commented Jul 29, 2024

make negative edition more general by checking card.ability.cardarea parameter and card.area. Since cardarea isn't created out of a run, I set card.ability.cardarea to be a string and SMOD looks up G[card.ability.cardarea]. Also buy_from_shop moves consumeables to ability.cardarea if it exists.

…parameter and card.area. Since cardarea isn't created out of a run, I set card.ability.cardarea to be a string and SMOD looks up G[card.ability.cardarea]. Also buy_from_shop moves consumeables to ability.cardarea if it exists.
@betmma
Copy link
Author

betmma commented Jul 29, 2024

oops the title is too long :(
G[card.ability.cardarea] is not very ideal but is the best I can come up with, so any other implementations are welcome

@Aurelius7309
Copy link
Collaborator

I think a better solution would be to have a function defined on the center object retrieve the card area. This would also be easier to set up for all objects of a class. Though I'm also not entirely sure what the whole card.ability.cardarea is needed for in determining which card area to change, shouldn't it just always be the area the card is in?

@Aurelius7309 Aurelius7309 changed the title make negative edition more general by checking card.ability.cardarea parameter and card.area. Since cardarea isn't created out of a run, I set card.ability.cardarea to be a string and SMOD looks up G[card.ability.cardarea]. Also buy_from_shop moves consumeables to ability.cardarea if it exists. Negative edition: Better cardarea support Jul 29, 2024
@Aurelius7309
Copy link
Collaborator

That title was a description 💀

@betmma
Copy link
Author

betmma commented Jul 29, 2024

what the whole card.ability.cardarea is needed for in determining which card area to change, shouldn't it just always be the area the card is in?

add_do_deck is called before cardarea:emplace(card) so in add_to_deck function card.area hasn't been set. I think another solution could be moving code that changes area size to cardarea:emplace

@Aurelius7309
Copy link
Collaborator

I don't think that'll work well with debuffed cards

@Aurelius7309 Aurelius7309 added the stale No progress seen recently, not in a mergeable state label Oct 30, 2024
@DigitalDetective47
Copy link
Contributor

shouldn't it just always be the area the card is in?

natural negatives in the shop shouldn't increase shop joker slots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale No progress seen recently, not in a mergeable state
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants