-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Negative edition: Better cardarea support #214
base: main
Are you sure you want to change the base?
Conversation
…parameter and card.area. Since cardarea isn't created out of a run, I set card.ability.cardarea to be a string and SMOD looks up G[card.ability.cardarea]. Also buy_from_shop moves consumeables to ability.cardarea if it exists.
oops the title is too long :( |
I think a better solution would be to have a function defined on the center object retrieve the card area. This would also be easier to set up for all objects of a class. Though I'm also not entirely sure what the whole |
That title was a description 💀 |
add_do_deck is called before cardarea:emplace(card) so in add_to_deck function card.area hasn't been set. I think another solution could be moving code that changes area size to cardarea:emplace |
I don't think that'll work well with debuffed cards |
natural negatives in the shop shouldn't increase shop joker slots |
make negative edition more general by checking card.ability.cardarea parameter and card.area. Since cardarea isn't created out of a run, I set card.ability.cardarea to be a string and SMOD looks up G[card.ability.cardarea]. Also buy_from_shop moves consumeables to ability.cardarea if it exists.