Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Better Calc 2.0 #373

Merged
merged 33 commits into from
Jan 7, 2025
Merged

Fix Better Calc 2.0 #373

merged 33 commits into from
Jan 7, 2025

Conversation

GauntletGames-2086
Copy link
Collaborator

@GauntletGames-2086 GauntletGames-2086 commented Jan 6, 2025 •
edited by Eremel
Loading

Current discovered issues (check = resolved):

  • Patches are not landing.
  • Crash at end of round when joker gives a payout.
  • Foil and Holo do not give chips/mult.
  • Gold Cards do not give dollars.
  • Mult goes before chips on enhancement (e.x. Mult Card).
  • Jokers using context.individual do not juice cards correctly. In vanilla, mult message appears on top of card and both juice. SMODS now displays mult below joker, and playing card does not juice.
  • Stone Card and Wild Card do not work
  • Red Seal's "Again!" shows up regardless of if it was played
  • Purple Seal will give two tarot cards instead of one
  • Blueprint cancels any non-blueprintable calculation that happens after it

@GauntletGames-2086 GauntletGames-2086 marked this pull request as ready for review January 6, 2025 04:11
@GauntletGames-2086 GauntletGames-2086 marked this pull request as draft January 6, 2025 04:16
@GauntletGames-2086
Copy link
Collaborator Author

sorry I forgor that there's simply WAAAY too much broken

GauntletGames-2086 and others added 25 commits January 5, 2025 19:18
@GauntletGames-2086
whoopsie
52b3cf7
@GauntletGames-2086
Foil/Holo now work correctly
3847436
@GauntletGames-2086
Fix Gold Card not giving dollars
d3bf533
@jumbocarrot0
Fixed individual card juicing (for stuff like even steven)
9ab0d39
@jumbocarrot0
Disable post_trig for now
b75ae58
@jumbocarrot0
some baseball card fixes
4b82b0b
@jumbocarrot0
Fixes to purple seal
ba24bc1
@jumbocarrot0
gold card fixes
370e9b4
@jumbocarrot0
Merge branch 'fix_bettercalc_2' of https://github.com/Steamopollys/St…
e302461 
…eamodded into fix_bettercalc_2
@GauntletGames-2086
Fix effect handling order
21a2e3c
@Aurelius7309
Merge pull request #375 from jumbocarrot0/fix_bettercalc_2
b34644e 
More fixes
@Aurelius7309
Denest post_trigger effect tables
2acac57
@Eremel
Fix purple seal properly
967decf
@Eremel
fix perishable triggers
5bbd3df
@Eremel
Edition full fix, context.pre_joker and context.post_joker
8b56919
@Eremel
fix key
add0dea
@Eremel
remove debug stuff
d2be2c6
@Eremel
remove unnecessary post_trigger returns
9177afa
@Eremel
fix enhancements
bbd28ab
@Eremel
fix red seal message
7e1d78e
@Eremel
juice_up timing error
04dc98e
@Eremel
Revert "remove unnecessary post_trigger returns"
0e50d84 
This reverts commit 9177afa.
@Aurelius7309
Fix blueprint messing with non-blueprintable calculations
0ee01a0
@Aurelius7309
Merge branch 'fix_bettercalc_2' of https://github.com/steamodded/smods …
abe4dff 
…into fix_bettercalc_2
@Eremel
fix end of round held in hand repetition
dd868b0
@GauntletGames-2086 GauntletGames-2086 marked this pull request as ready for review January 7, 2025 00:02
@GauntletGames-2086
Copy link
Collaborator Author

All currently known issues have been resolved, and any future ones are (likely) to not be destructive enough to just fix on main. AKA ready to merge.

@Eremel Eremel merged commit e053d16 into main Jan 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GauntletGames-2086 @Eremel @jumbocarrot0 @Aurelius7309