Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle year fmt in from_millis fn #144

Merged
merged 2 commits into from
Nov 20, 2024
Merged

fix: handle year fmt in from_millis fn #144

merged 2 commits into from
Nov 20, 2024

Conversation

deepakraog
Copy link
Contributor

bug: $fromMillis various issues #140

@deepakraog deepakraog added the bug Something isn't working label Nov 19, 2024
@deepakraog deepakraog self-assigned this Nov 19, 2024
@deepakraog deepakraog requested a review from a team as a code owner November 19, 2024 05:20
@deepakraog deepakraog changed the title fix: handle year fmt in from millis fn fix: handle year fmt in from_millis fn Nov 19, 2024
@deepakraog deepakraog merged commit d9b4c5a into main Nov 20, 2024
8 checks passed
@deepakraog deepakraog deleted the fix/from_millis_yr_fmt branch November 20, 2024 04:23
@stedi-release-plz stedi-release-plz bot mentioned this pull request Nov 20, 2024
Merged
hugobast
hugobast reviewed Nov 20, 2024
View reviewed changes
Copy link

@hugobast hugobast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugobast hugobast hugobast left review comments

@tommy tommy tommy approved these changes

@aesterline aesterline aesterline approved these changes

Assignees

@deepakraog deepakraog

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deepakraog @aesterline @tommy @hugobast