-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add browsing scanning feature through mitmproxy #145
base: master
Are you sure you want to change the base?
Conversation
…when network is down
Co-authored-by: Mick Nassar <[email protected]>
5251a87
to
c251294
Compare
Interesting… is there a particular use case for this? Or in which ways is this better than just setting the proxy setting and starting mitmweb yourself? |
Actually had another look and I think it would be easier to achieve a similar result via --print-traffic Display sent and read HTTP traffic |
This option only output the traffic of ydl not the browser traffic The purpose of the feature is to scan browser traffic to find videos (only HLS and video partial content for the moment) |
Any though? Do you think it worth to work on a proper pr? or do i keep my version as a fork? |
Currently I still did not quite get the use case for it, so likely keep it as a fork. I will take another look in December though when I have some more time |
so basically like a browser extension? |
A browser extension can't do what ffmpeg can do. How the feature works: One can easily extends traffic analysis to find more urls compatibles with ydl I also just code something working for livestream but it's a bit dirty (not sure a ffmpeg pass might be required for the file to be clean) |
A typical use case is when page of the video is dynamically loaded page with javascript...so you can't get the url without further digging. But what's interesting is that it pass headers to ydl such as mandatory referer for cross domain embed videos. |
not to merge right now..just for review to know if you'll have some interest about such a feature...
How the feature works:
When browsing through proxy all traffic is sent to OpenVideoDownloader on port 1200 as json and then can be analysed easily to find standard streaming tech in request response (HLS,Dash,partial-content video) then url and request headers are sent to ydl for download...
Check build here: https://github.com/mp3butcher/youtube-dl-gui/releases/latest
(Note: I dl mitmproxy from https://github.com/mp3butcher/mitmproxy for zip convenience but you can check I haven't changed anything).
I added macos build too but haven't check if it works, so feel free to report macos problem here
A typical use case for this feature is when page of the video is dynamically loaded with javascript. But what's interesting is that it passes headers to ydl such as the mandatory referer for cross domain embed videos.
How to use scanner: