Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 145 #147

Merged
merged 2 commits into from
Oct 20, 2022
Merged

fix issue 145 #147

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa2149c
fix issue 145
rxliuli Oct 8, 2022
09bee70
chore: resolve conversation
rxliuli Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/AdaptivePopover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,11 @@ export default class AdaptivePopover extends Component<AdaptivePopoverProps, Ada
count = 0;
do {
rect = await getRectForRef(fromRef);
// console.log('rect', rect)
rxliuli marked this conversation as resolved.
Show resolved Hide resolved
if ([rect.x, rect.y, rect.width,rect.height].every(i => i === undefined)) {
console.log('rect not found')
rxliuli marked this conversation as resolved.
Show resolved Hide resolved
return
}
rect = new Rect(rect.x + horizontalOffset, rect.y + verticalOffset, rect.width, rect.height);

await new Promise(resolve => {
Expand Down