-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
save pose graph when merging map #196
base: melodic-devel
Are you sure you want to change the base?
Conversation
@@ -248,8 +251,24 @@ bool MergeMapsKinematic::mergeMapCallback( | |||
tf2::Transform submap_correction = submap_marker_transform_[id]; | |||
transformScan(iter, submap_correction); | |||
transformed_scans.push_back((*iter)); | |||
|
|||
if (iter == it_LRV->begin() && id != 1){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a space between ) {
. Also you didn't indent your if/else code. Finally, remove all spaces between pointer accessors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - small thing.
My action items after that's fixed:
- test locally with rviz plugin
- merge
- cherry pick to noetic / ROS2
|
||
// transform all the scans into the new global map coordinates | ||
int id = 0; | ||
bool processed = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't use this variable. You can just ignore the return type if you're not checking its validity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, done.
And I am developing the lifelong merge, I am planning to add a new service something like "lifelong merge", it works as lifelong to decay old node when merge pose graph , if you want, I can create another PR after I finish.
Co-Authored-By: Steve Macenski <[email protected]>
Hello, we have a problem here, for example, if I use lifelong mode, after about 20 minutes , the map will drift, the dock position in the map frame will not be 100% same as initial map. What is your opinion about this problem ? Thank you. |
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Future work that may be required in bullet points