-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualize inter and intra constraint (like cartographer_ros) localization nodes and edges with different colors in the pose graph marker message. #550
Open
suryakanths
wants to merge
13
commits into
SteveMacenski:melodic-devel
Choose a base branch
from
suryakanths:melodic-constraints-viz
base: melodic-devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suryakanths
changed the title
Melodic constraints viz
Visualize inter and intra constraint (like cartographer_ros) localization nodes and edges with different colors in the pose graph marker message.
Nov 11, 2022
Revert all unnecessary code reformatting before this can be reviewed. |
Still a bit more from the diff -- this is to make this readable for me to do a review |
i have removed all the unwanted changes please check now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Inter and intra constrains are split with respective name space and colors for mappping and localization
Intra constraints where edges are connected to same graph on consecutive nodes
inter constraints where edges are connected to a different graph or non consecutive nodes
rom 2022-11-11 17-02-00.png…]()
#Visualize slam nodes and localization edges in different namespace
Description of documentation updates required from your changes
Separated the nodes into slam and localization names spaces
Edges are separated as inter and intra for localization and mapping namespace
Future work that may be required in bullet points