Test for IOTDB-1818 (Sourcery refactored) #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-741
to
+743
| for i in range(1, len(timestamps)): | ||
| if timestamps[i] < timestamps[i - 1]: | ||
| return False | ||
| return True | ||
| return all( | ||
| timestamps[i] >= timestamps[i - 1] for i in range(1, len(timestamps)) | ||
| ) |
There was a problem hiding this comment.
Function Session.check_sorted refactored with the following changes:
- Use any() instead of for loop (
use-any) - Invert any/all to simplify comparisons (
invert-any-all)
| for i in range (size // 8 + 1): | ||
| for _ in range (size // 8 + 1): |
There was a problem hiding this comment.
Function BitMap.__init__ refactored with the following changes:
- Replace unused for index with underscore (
for-index-underscore)
Comment on lines
-65
to
+67
| for i in range(1, len(timestamps)): | ||
| if timestamps[i] < timestamps[i - 1]: | ||
| return False | ||
| return True | ||
| return all( | ||
| timestamps[i] >= timestamps[i - 1] for i in range(1, len(timestamps)) | ||
| ) |
There was a problem hiding this comment.
Function Tablet.check_sorted refactored with the following changes:
- Use any() instead of for loop (
use-any) - Invert any/all to simplify comparisons (
invert-any-all)
Comment on lines
-83
to
+92
| if not self.__use_new: | ||
| format_str_list = [">"] | ||
| values_tobe_packed = [] | ||
| for timestamp in self.__timestamps: | ||
| format_str_list.append("q") | ||
| values_tobe_packed.append(timestamp) | ||
|
|
||
| format_str = "".join(format_str_list) | ||
| return struct.pack(format_str, *values_tobe_packed) | ||
| else: | ||
| if self.__use_new: | ||
| return self.__timestamps.tobytes() | ||
|
|
||
| format_str_list = [">"] | ||
| values_tobe_packed = [] | ||
| for timestamp in self.__timestamps: | ||
| format_str_list.append("q") | ||
| values_tobe_packed.append(timestamp) | ||
|
|
||
| format_str = "".join(format_str_list) | ||
| return struct.pack(format_str, *values_tobe_packed) |
There was a problem hiding this comment.
Function Tablet.get_binary_timestamps refactored with the following changes:
- Swap if/else branches (
swap-if-else-branches) - Remove unnecessary else after guard condition (
remove-unnecessary-else)
Comment on lines
+160
to
+171
| format_str_list.append("i") | ||
| if self.__values[j][i] is not None: | ||
| value_bytes = bytes(self.__values[j][i], "utf-8") | ||
| format_str_list.append("i") | ||
| format_str_list.append(str(len(value_bytes))) | ||
| format_str_list.append("s") | ||
| values_tobe_packed.append(len(value_bytes)) | ||
| values_tobe_packed.append(value_bytes) | ||
| else: | ||
| value_bytes = bytes("", "utf-8") | ||
| format_str_list.append("i") | ||
| format_str_list.append(str(len(value_bytes))) | ||
| format_str_list.append("s") | ||
| values_tobe_packed.append(len(value_bytes)) | ||
| values_tobe_packed.append(value_bytes) | ||
| self.__mark_none_value(bitmaps, bitmap, i, j) | ||
| has_none = True | ||
|
|
||
| format_str_list.append(str(len(value_bytes))) | ||
| values_tobe_packed.append(len(value_bytes)) | ||
| values_tobe_packed.append(value_bytes) | ||
| format_str_list.append("s") |
There was a problem hiding this comment.
Function Tablet.get_binary_values refactored with the following changes:
- Hoist repeated code outside conditional statement (
hoist-statement-from-if)
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.39%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #27 refactored by Sourcery.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Incorporate changes via command line
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Help us improve this pull request!