-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supports Laravel 12 #40
base: master
Are you sure you want to change the base?
Conversation
Thought I'd move the Mockery requirement to the composer.json since it'll always be run anyway.
@@ -40,14 +40,6 @@ jobs: | |||
extensions: dom, curl, libxml, mbstring, zip, pcntl, pdo, sqlite, pdo_sqlite, bcmath, soap, intl, gd, exif, iconv, imagick, fileinfo | |||
coverage: none | |||
|
|||
- name: Set PHP 8 Mockery |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed this workflow step in favour of requiring Mockery directly in the package's composer.json
file. If you'd prefer to keep it here, feel free to revert 0101ca47
.
@@ -6,5 +6,5 @@ Thumbs.db | |||
/phpunit.xml | |||
/.idea | |||
/.vscode | |||
.phpunit.result.cache | |||
.phpunit.cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While running the test suite locally, I noticed that the PHPUnit cache directory wasn't ignored. I think the naming changed fairly recently, so just reflecting that here.
@JohnathonKoster Are you able to re-trigger the GitHub Actions workflow for my latest commit? |
This pull requests adds Laravel 12 support to the
blade-parser
package. It also drops support for Laravel 9 and PHP 8.1.