Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign multiple PDF pages at the same time in the same location (#2008) #2278

Conversation

thisisrenan
Copy link
Contributor

Description

Adding the functionality to sign multiple pages at once.

The following files were modified:

  • Modified: `src/main/resources/static/css/sign.css
  • Modified: src/main/resources/static/js/draggable-utils.js
  • Modified: src/main/resources/templates/sign.html

File: sign.html and sign.css

Two buttons were added to toggle between manually adding or automatically adding signatures.

tabFront

A script was also added to define which functionality will be used, specify what actions are allowed for each, and clear any previously placed signatures if the functionality is changed.

funcFront

The screen looks like this

UI

File: raggable-utils.js

A new function was added to allow navigating to any page in the canvas by its index.

goToPage

Additionally, the signature drawing function was modified to include a boolean flag that, if enabled, copies the signature from the first page to the others when signing multiple pages at once.

bool

Closes #2008

Checklist

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have attached images of the change if it is UI based
  • I have commented my code, particularly in hard-to-understand areas
  • If my code has heavily changed functionality I have updated relevant docs on Stirling-PDFs doc repo
  • My changes generate no new warnings
  • I have read the section Add New Translation Tags (for new translation tags only)

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Nov 20, 2024
@github-actions github-actions bot added the Front End Issues or pull requests related to front-end development label Nov 20, 2024
@dosubot dosubot bot added the enhancement New feature or request label Nov 20, 2024
@Frooodle
Copy link
Member

/deploypr

Copy link
Contributor

🚀 PR Test Deployment

Your PR has been deployed for testing!

🔗 Test URL: http://185.252.234.121:2278

This deployment will be automatically cleaned up when the PR is closed.

<li class="nav-item">
<button class="nav-link active btn-custom " id="manualSignatureTab" data-bs-toggle="pill"
onclick="manualOrAll(false)">
Add Signature Manually
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text must be via messages.properties not static, to allow user translations

<li class="nav-item">
<button class="nav-link btn-custom " id="allPagesSignatureTab" data-bs-toggle="pill"
onclick="manualOrAll(true)">
Add Signature to All Pages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same translation



.btn-custom {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think with the rest of the UI being rounded these buttons seem very out of place, additionally the offsetting when one is disabled could probably be more clear.
It also needs a bit more padding distance from the tabs below it (or maybe moving under the signature entry stuff? not sure)

@Frooodle
Copy link
Member

/deploypr

Copy link
Contributor

🚀 PR Test Deployment

Your PR has been deployed for testing!

🔗 Test URL: http://185.252.234.121:2278

This deployment will be automatically cleaned up when the PR is closed.

…lementing buttons to navigate to the first and last pages (Stirling-Tools#2008)
@Frooodle
Copy link
Member

/deploypr

Copy link
Contributor

🚀 PR Test Deployment

Your PR has been deployed for testing!

🔗 Test URL: http://185.252.234.121:2278

This deployment will be automatically cleaned up when the PR is closed.

@Frooodle Frooodle merged commit 204bae3 into Stirling-Tools:main Nov 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Front End Issues or pull requests related to front-end development size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Sign multiple PDF pages at the same time in the same location
2 participants