-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign multiple PDF pages at the same time in the same location (#2008) #2278
Sign multiple PDF pages at the same time in the same location (#2008) #2278
Conversation
/deploypr |
🚀 PR Test DeploymentYour PR has been deployed for testing! 🔗 Test URL: http://185.252.234.121:2278 This deployment will be automatically cleaned up when the PR is closed. |
<li class="nav-item"> | ||
<button class="nav-link active btn-custom " id="manualSignatureTab" data-bs-toggle="pill" | ||
onclick="manualOrAll(false)"> | ||
Add Signature Manually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text must be via messages.properties not static, to allow user translations
<li class="nav-item"> | ||
<button class="nav-link btn-custom " id="allPagesSignatureTab" data-bs-toggle="pill" | ||
onclick="manualOrAll(true)"> | ||
Add Signature to All Pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same translation
|
||
|
||
.btn-custom { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think with the rest of the UI being rounded these buttons seem very out of place, additionally the offsetting when one is disabled could probably be more clear.
It also needs a bit more padding distance from the tabs below it (or maybe moving under the signature entry stuff? not sure)
/deploypr |
🚀 PR Test DeploymentYour PR has been deployed for testing! 🔗 Test URL: http://185.252.234.121:2278 This deployment will be automatically cleaned up when the PR is closed. |
…lementing buttons to navigate to the first and last pages (Stirling-Tools#2008)
/deploypr |
🚀 PR Test DeploymentYour PR has been deployed for testing! 🔗 Test URL: http://185.252.234.121:2278 This deployment will be automatically cleaned up when the PR is closed. |
Description
Adding the functionality to sign multiple pages at once.
The following files were modified:
src/main/resources/static/js/draggable-utils.js
src/main/resources/templates/sign.html
File:
sign.html
andsign.css
Two buttons were added to toggle between manually adding or automatically adding signatures.
A script was also added to define which functionality will be used, specify what actions are allowed for each, and clear any previously placed signatures if the functionality is changed.
The screen looks like this
File:
raggable-utils.js
A new function was added to allow navigating to any page in the canvas by its index.
Additionally, the signature drawing function was modified to include a boolean flag that, if enabled, copies the signature from the first page to the others when signing multiple pages at once.
Closes #2008
Checklist