Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update react-native-popover-view to v1.0.7 #2875

Merged
merged 2 commits into from
Aug 26, 2018
Merged

Update react-native-popover-view to v1.0.7 #2875

merged 2 commits into from
Aug 26, 2018

Conversation

hawkrives
Copy link
Member

@hawkrives hawkrives commented Aug 25, 2018 •
edited
Loading

Closes #2874

@hawkrives
Copy link
Member Author

We may also need to add the react-navigation package: SteffeyDev/react-native-popover-view#17 (comment)

@hawkrives
Copy link
Member Author

Looking through https://github.com/SteffeyDev/react-navigation-popover, I don't think we need that.

@hawkrives hawkrives changed the title react native popover view v1.0.7 Update react-native-popover-view to v1.0.7 Aug 26, 2018
@hawkrives
Copy link
Member Author

image

Works. Yay.

@hawkrives
Copy link
Member Author

Also, it might have fixed https://github.com/SteffeyDev/react-native-popover-view/issues/2… I think

@hawkrives hawkrives requested a review from a team August 26, 2018 14:34
@hawkrives hawkrives added this to the v2.6 milestone Aug 26, 2018
@hawkrives hawkrives merged commit 5caa4a6 into master Aug 26, 2018
@greenkeeper greenkeeper bot deleted the greenkeeper/react-native-popover-view-1.0.7 branch August 26, 2018 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewvolz drewvolz drewvolz approved these changes

@rye rye rye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hawkrives @rye @drewvolz @greenkeeperio-bot