adding test to check all notebooks. #196
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d in same testing instance as test_model and test_solver, however it takes a very long time to run. A timeout is given to each cell of 10 minutes, and cells that exceed this timeout report erroneous and will cause the test to fail. This is a naive implementation which will execute all notebooks contained in the examples directory, and may need to be modified to operate on or be able to select a minimal set of notebooks which meet a stricter runtime criteria. Additionally, it may be worth separating these tests to be executed by a different action to prevent unwanted failures from notebooks causing the main testing routine to fail.
seanebum
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test is currently implemented in same testing instance as test_model and test_solver, however it takes a very long time to run. A timeout is given to each cell of 10 minutes, and cells that exceed this timeout report erroneous and will cause the test to fail. This is a naive implementation which will execute all notebooks contained in the examples directory, and may need to be modified to operate on or be able to select a minimal set of notebooks which meet a stricter runtime criteria. Additionally, it may be worth separating these tests to be executed by a different action to prevent unwanted failures from notebooks causing the main testing routine to fail. This PR closes #181