Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating OpenMPI from 1.8.1 -> 5.0.5 #1401

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Updating OpenMPI from 1.8.1 -> 5.0.5 #1401

merged 1 commit into from
Oct 7, 2024

Conversation

wwlwpd
Copy link
Collaborator

@wwlwpd wwlwpd commented Oct 6, 2024

Issue 1400: ASGS attempts to build OpenMPI when it can't find mpif90, and for the longest time it was providing an "ancient" version (1.8.1). Recent attempts to support Ubuntu 22 had provided enough motivation to update this version of OpenMPI to the latest current upstream version, which is 5.0.5. It is likely this change will impact older operating systems which needed 1.8.1 to be installed. If this occurs, it should be noted there that ASGS only needs there to be an mpif90 for compiling ADCIRC. It doesn't care itself how that is provided. But the successful building of ADCIRC does require that the mpif90 available via PATH be compatible with the C and Fortran compilers that are also being used by everything else.

The reason this upgrade was necessary is because Ubuntu 24.x started providing some development libraries that were no longer compatible with what OpenMPI 1.8.1 was expecting.

Resolves #1400.

Issue 1400: ASGS attempts to build OpenMPI when it can't find `mpif90`,
and for the longest time it was providing an "ancient" version (1.8.1).
Recent attempts to support Ubuntu 22 had provided enough motivation to
update this version of OpenMPI to the latest current upstream version,
which is 5.0.5. It is likely this change will impact older operating
systems which needed 1.8.1 to be installed. If this occurs, it should
be noted there that ASGS only needs there to be an `mpif90` for
compiling ADCIRC. It doesn't care itself how that is provided. But the
successful building of ADCIRC does require that the `mpif90` available
via PATH be compatible with the C and Fortran compilers that are also
being used by everything else.

The reason this upgrade was necessary is because Ubuntu 22.x started
providing some development libraries that were no longer compatible
with what OpenMPI 1.8.1 was expecting.

Resolves #1400.
@wwlwpd wwlwpd requested a review from jasonfleming as a code owner October 6, 2024 21:01
@wwlwpd
Copy link
Collaborator Author

wwlwpd commented Oct 6, 2024

I tested this on Ubuntu 24.04.1 LTS (currently latest default on Windows WSL2). builds all ADCIRCs we care about, and verify adcirc confirmed that MPI works for all of them during run time.

This will remain a skipped step if asgs-brew.pl finds mpif90inPATH` (like on all the HPCs or environments where MPI has already been installed). That may need to be updated when integrating Intel OneAPI support for the Ubuntu/WSL2 environment.

Copy link
Collaborator

@jasonfleming jasonfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @wwlwpd ... let me know if there is a need to add a file archive for this version of openmpi to our digitalocean space.

@wwlwpd
Copy link
Collaborator Author

wwlwpd commented Oct 7, 2024

This looks great @wwlwpd ... let me know if there is a need to add a file archive for this version of openmpi to our digitalocean space.

I do not think there is a need, but if you wanted to I would be happy to adjust the URL.

@wwlwpd wwlwpd merged commit 7bdc2f9 into master Oct 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update provided OpenMPI (when mpif90 is not already present) from 1.8.1 -> 5.0.5 (latest)
2 participants