Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made regexp extracting GFS directy names more robust. #1410

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

wwlwpd
Copy link
Collaborator

@wwlwpd wwlwpd commented Nov 1, 2024

Issue 1409: It seems the directory listing HTML changed, and this caused the regexp extracting the GFS directory names to capture HTML elements, thus making the names always invalid.

Resolves #1409.
Resolves #1410 (PR).

@wwlwpd wwlwpd self-assigned this Nov 1, 2024
Issue 1409: It seems the directory listing HTML changed, and this
caused the regexp extracting the GFS directory names to capture
HTML elements, thus making the names always invalid.

Resolves #1409.
Resolves #1410 (PR).
@wwlwpd wwlwpd marked this pull request as ready for review November 1, 2024 06:38
@wwlwpd wwlwpd requested a review from jasonfleming as a code owner November 1, 2024 06:38
Copy link
Collaborator

@jasonfleming jasonfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @wwlwpd, thank you!

@wwlwpd wwlwpd merged commit 93cc670 into master Nov 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GFS directory listing parsing regex broke with upstream HTML change (maybe)
2 participants