Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Panic on root $id without base #556

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

Stranger6667
Copy link
Owner

Fixes #547

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.38%. Comparing base (d07e47f) to head (3b8160c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
crates/jsonschema/src/retriever.rs 42.85% 4 Missing ⚠️
crates/jsonschema-referencing/src/registry.rs 93.75% 1 Missing ⚠️
crates/jsonschema/src/output.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
+ Coverage   86.37%   86.38%   +0.01%     
==========================================
  Files          88       88              
  Lines       12392    12395       +3     
==========================================
+ Hits        10703    10708       +5     
+ Misses       1689     1687       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Oct 3, 2024

CodSpeed Performance Report

Merging #556 will degrade performances by 10.57%

Comparing dd/fix-ref-panic (3b8160c) with master (d07e47f)

Summary

❌ 1 regressions
✅ 38 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master dd/fix-ref-panic Change
is_valid[Fast/Invalid] 740 ns 827.5 ns -10.57%

@Stranger6667 Stranger6667 merged commit 3094138 into master Oct 3, 2024
31 of 33 checks passed
@Stranger6667 Stranger6667 deleted the dd/fix-ref-panic branch October 3, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic in LazyRefValidator::lazy_compile with jsonschema 0.21
1 participant