Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return "Unknown specification" error on https-prefixed $schema for Draft 4, 5, 6 #631

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

Stranger6667
Copy link
Owner

@Stranger6667 Stranger6667 commented Oct 29, 2024

Resolves #629

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.90%. Comparing base (832d7d1) to head (e677437).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
crates/jsonschema/src/options.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #631      +/-   ##
==========================================
+ Coverage   87.88%   87.90%   +0.01%     
==========================================
  Files          92       92              
  Lines       13307    13318      +11     
==========================================
+ Hits        11695    11707      +12     
+ Misses       1612     1611       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Oct 29, 2024

CodSpeed Performance Report

Merging #631 will not alter performance

Comparing dd/fix-schema-https (e677437) with master (832d7d1)

Summary

✅ 45 untouched benchmarks

@Stranger6667 Stranger6667 merged commit a2eb0ff into master Oct 29, 2024
38 checks passed
@Stranger6667 Stranger6667 deleted the dd/fix-schema-https branch October 29, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Python] Validation error when upgrading from 0.18.x to 0.26.0
1 participant