This repository has been archived by the owner on May 27, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
use_ttl
new option.use_ttl = false
, disable unnecessary partition reading at compaction.describe
I was investigating the compaction speed when enabling this plug-in.
When SSTable increased, the speed of compaction fell below 1%. I anticipate that read latency will be higher. Then I checked if it really needed partition reading at compaction time.
72c4875#diff-298e208e90f66d25100b3cd7dbf19d5bR71
This code was added for support TTL . If do not use TTL, this overhead is unnecessary ...? I put in debugging code in IndexWriterWide#commit(). What is SinglePartitionReadCommand reading when transactiontype == COMPACTION? As a result, did not read anything. So I added a flag to disable this.
(I do not fully understand the life cycle of Cassandra Indexer. Please point out if there is a mistake.)