This repository has been archived by the owner on Dec 24, 2024. It is now read-only.
Fix signext WASM instructions on iOS 14 Safari #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for your PR! Could you please open this PR in https://github.com/Stremio/stremio-core/ as we've merged stremio-core-web in one repo with stremio-core. |
|
Sure! Will do later today |
|
Moved to Stremio/stremio-core#704 :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119, read there for more details.
Essentially, iOS 14 Safari does not support these WASM instructions, and this simple change allows stremio to load without WASM errors.