Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: home login modal #219

Merged
merged 3 commits into from
Jan 27, 2024
Merged

Feat: home login modal #219

merged 3 commits into from
Jan 27, 2024

Conversation

Yamyam-code
Copy link
Member

@Yamyam-code Yamyam-code commented Jan 27, 2024

개요

스크린샷

주요 내용

  • 홈화면 로그인 요구 모달 추가
  • 찜 버튼 오류 수정
  • 상세페이지 url에 타이틀 파라미터 추가 (?title=title)

고민한 점, 질문거리

발행된 이슈 연결 후 머지 후 자동 클로즈, 브랜치 삭제 연결

@Yamyam-code Yamyam-code added this to the TripVote FE development milestone Jan 27, 2024
@Yamyam-code Yamyam-code self-assigned this Jan 27, 2024
@Yamyam-code Yamyam-code linked an issue Jan 27, 2024 that may be closed by this pull request
1 task
Copy link

vercel bot commented Jan 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
trip-vote-fe ✅ Ready (Inspect) Visit Preview Jan 27, 2024 3:02am

@Yamyam-code Yamyam-code merged commit 4b06530 into dev Jan 27, 2024
3 checks passed
@Yamyam-code Yamyam-code deleted the 216-feat-home-login-modal branch January 27, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

Feat: home login modal
4 participants