Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add scroll to top logic show gnb login alert #281

Merged

Conversation

NamgungJongMin
Copy link
Member

개요

비로그인시 gnb 클릭시 로그인 이동 모달 추가
페이지 이동시 스크롤 상단으로 초기화 로직 추가
로딩 애니메이션 크기 조절

스크린샷

주요 내용

  • 비로그인시 gnb 클릭시 로그인 이동 모달 추가
  • 페이지 이동시 스크롤 상단으로 초기화 로직 추가
  • 로딩 애니메이션 크기 조절

고민한 점, 질문거리

발행된 이슈 연결 후 머지 후 자동 클로즈, 브랜치 삭제 연결

@NamgungJongMin NamgungJongMin self-assigned this Jan 28, 2024
@NamgungJongMin NamgungJongMin linked an issue Jan 28, 2024 that may be closed by this pull request
2 tasks
Copy link

vercel bot commented Jan 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
trip-vote-fe ✅ Ready (Inspect) Visit Preview Jan 28, 2024 5:57pm

@NamgungJongMin NamgungJongMin merged commit b495981 into dev Jan 28, 2024
3 checks passed
@NamgungJongMin NamgungJongMin deleted the 273-feat-add-scroll-to-top-logic-show-gnb-login-alert branch January 28, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

Feat: add scroll to top logic & show gnb login alert
1 participant