Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch latest "stable" build from update check endpoint #21

Merged
merged 4 commits into from
Jan 12, 2025

Conversation

FichteFoll
Copy link
Member

Also support new "binary" value for packages ref to automatically use the same build tag as for the binary.

Addresses the second point of #6 that should arguably have been its own issue.

This leads to fewer lines changed when updating descriptions.
Also support new "binary" value for packages ref to automatically use
the same build tag as for the binary.
@FichteFoll FichteFoll added this to the v2.4 milestone Jan 12, 2025
@FichteFoll FichteFoll requested a review from deathaxe January 12, 2025 14:23
Copy link
Member

@deathaxe deathaxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We may fetch tags from Packages repo to ensure to have a valid reference, even if binary points to not yet existing tag.

Maybe better to write an action for Packages which checks the update end point and creates tags automatically :-D

syntax-tests.sh Outdated Show resolved Hide resolved
@FichteFoll
Copy link
Member Author

Maybe better to write an action for Packages which checks the update end point and creates tags automatically :-D

The problem here is that we cannot simply tag the current master but need to check which version of the repo was actually included in the release. Anyway, that's for another time (and another repo).

Copy link
Member

@deathaxe deathaxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FichteFoll FichteFoll merged commit 583ec32 into master Jan 12, 2025
16 checks passed
@FichteFoll FichteFoll deleted the feature/latest-stable branch January 12, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants