Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: restore parallelism #317

Merged
merged 3 commits into from
Feb 16, 2024
Merged

chore: restore parallelism #317

merged 3 commits into from
Feb 16, 2024

Conversation

SdgJlbl
Copy link
Contributor

@SdgJlbl SdgJlbl commented Feb 13, 2024

No description provided.

@SdgJlbl SdgJlbl requested a review from a team as a code owner February 13, 2024 16:43
@SdgJlbl
Copy link
Contributor Author

SdgJlbl commented Feb 13, 2024

/e2e tests=sdk

@Owlfred
Copy link

Owlfred commented Feb 13, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

“Success is not final; failure is not fatal: It is the courage to continue that counts.” ―- Winston S. Churchill

@ThibaultFy
Copy link
Member

There is a weird error, surely due to a merge conflict: AssertionError: assert 'FUNCTION_STATUS_WAITING' == 'FUNCTION_STATUS_BUILDING'

Also, just so you know, the syntax for choosing the test to run is --tests sdk :)

@SdgJlbl
Copy link
Contributor Author

SdgJlbl commented Feb 14, 2024

There is a weird error, surely due to a merge conflict: AssertionError: assert 'FUNCTION_STATUS_WAITING' == 'FUNCTION_STATUS_BUILDING'

Also, just so you know, the syntax for choosing the test to run is --tests sdk :)

I think it's linked to the fact that we might need to wait a bit for the build to start, now that we are running tests in parallel again (and that the number of builders is smaller than the number of tests run in parallel).
I'm looking into how best test the behaviour.

@SdgJlbl SdgJlbl force-pushed the chore/restore-xdist branch 2 times, most recently from 29557e1 to db9eac3 Compare February 14, 2024 16:15
@Substra Substra deleted a comment from Owlfred Feb 14, 2024
@SdgJlbl SdgJlbl force-pushed the chore/restore-xdist branch from db9eac3 to 5188892 Compare February 15, 2024 16:34
@Substra Substra deleted a comment from Owlfred Feb 15, 2024
@SdgJlbl SdgJlbl force-pushed the chore/restore-xdist branch from 5188892 to 8b6d1bf Compare February 16, 2024 09:19
@SdgJlbl SdgJlbl force-pushed the chore/restore-xdist branch 2 times, most recently from 0ed5729 to 0f9c0c0 Compare February 16, 2024 14:52
@Substra Substra deleted a comment from Owlfred Feb 16, 2024
@SdgJlbl SdgJlbl force-pushed the chore/restore-xdist branch from 0f9c0c0 to 5787aff Compare February 16, 2024 15:25
@Substra Substra deleted a comment from Owlfred Feb 16, 2024
@Substra Substra deleted a comment from Owlfred Feb 16, 2024
@Substra Substra deleted a comment from Owlfred Feb 16, 2024
@Substra Substra deleted a comment from Owlfred Feb 16, 2024
@SdgJlbl SdgJlbl force-pushed the chore/restore-xdist branch 2 times, most recently from 7802411 to cf44c5e Compare February 16, 2024 16:27
@SdgJlbl
Copy link
Contributor Author

SdgJlbl commented Feb 16, 2024

/e2e --tests sdk --refs substra=feat/add-function-status

@Owlfred
Copy link

Owlfred commented Feb 16, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

@Substra Substra deleted a comment from Owlfred Feb 16, 2024
@SdgJlbl
fix: image build test
f284284 
Signed-off-by: SdgJlbl <[email protected]>
@SdgJlbl SdgJlbl force-pushed the chore/restore-xdist branch from cf44c5e to f284284 Compare February 16, 2024 17:00
guilhem-barthes
guilhem-barthes approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@guilhem-barthes guilhem-barthes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@SdgJlbl SdgJlbl merged commit 693bb5b into main Feb 16, 2024
6 checks passed
@SdgJlbl SdgJlbl deleted the chore/restore-xdist branch February 16, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilhem-barthes guilhem-barthes guilhem-barthes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SdgJlbl @Owlfred @ThibaultFy @guilhem-barthes