Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update ComputePlan statuses #320

Merged
merged 2 commits into from
Mar 5, 2024
Merged

feat: update ComputePlan statuses #320

merged 2 commits into from
Mar 5, 2024

Conversation

guilhem-barthes
Copy link
Contributor

@guilhem-barthes guilhem-barthes commented Feb 19, 2024 •
edited
Loading

Fixes FL-1422

@guilhem-barthes
Copy link
Contributor Author

/e2e --refs=orchestrator=feat/update-computeplan-status,substra-backend=feat/update-computeplan-status,substra=feat/update-computeplan-status

@Owlfred
Copy link

Owlfred commented Feb 19, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

“I’m sorry, Dave. I’m afraid I can’t do that.” ― Hal, 2001: A Space Odyssey

@Substra Substra deleted a comment from Owlfred Feb 19, 2024
@guilhem-barthes
Copy link
Contributor Author

/e2e --refs=orchestrator=feat/update-computeplan-status,substra-backend=feat/update-computeplan-status,substra=feat/update-computeplan-status

@Owlfred
Copy link

Owlfred commented Feb 19, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

Better luck next time!

@guilhem-barthes
Copy link
Contributor Author

/e2e --refs=orchestrator=feat/update-computeplan-status,substra-backend=feat/update-computeplan-status,substra=feat/update-computeplan-status --tests=doc,camelyon,mnist,substrafl,sdk

@Owlfred
Copy link

Owlfred commented Feb 19, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

“Success is not final; failure is not fatal: It is the courage to continue that counts.” ―- Winston S. Churchill

@linear Linear
Copy link

linear bot commented Feb 20, 2024

FL-1422 Update compute plan status

@guilhem-barthes guilhem-barthes force-pushed the feat/update-computeplan-status branch from 9d8e04c to 22a10e1 Compare February 26, 2024 16:13
@guilhem-barthes
Copy link
Contributor Author

/e2e --refs=orchestrator=feat/update-computeplan-status,substra-backend=feat/update-computeplan-status,substra=feat/update-computeplan-status --tests=doc,camelyon,mnist,substrafl,sdk

@Owlfred
Copy link

Owlfred commented Feb 26, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

“To infinity and beyond!” ― Buzz Lightyear, Toy Story

@guilhem-barthes
Copy link
Contributor Author

/e2e --refs=orchestrator=feat/update-computeplan-status,substra-backend=feat/update-computeplan-status,substra=feat/update-computeplan-status,substra-frontend=feat/update-computeplan-status --tests=doc,camelyon,mnist,substrafl,sdk

@Owlfred
Copy link

Owlfred commented Feb 27, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

@guilhem-barthes guilhem-barthes marked this pull request as ready for review February 27, 2024 09:30
@guilhem-barthes guilhem-barthes requested a review from a team as a code owner February 27, 2024 09:30
ThibaultFy
ThibaultFy approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@guilhem-barthes
Copy link
Contributor Author

/e2e --refs=orchestrator=feat/update-computeplan-status,substra-backend=feat/update-computeplan-status,substra=feat/update-computeplan-status,substra-frontend=feat/update-computeplan-status --tests=doc,camelyon,mnist,substrafl,sdk

@Owlfred
Copy link

Owlfred commented Mar 4, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

  • Camelyon / camelyon: ❌
  • Dispatch Jobs: ✔️
  • Documentation / doc: ❌
  • Frontend: ⏭️
  • MNIST / mnist: ❌
  • SubstraFL / substrafl: ❌
  • SubstraSDK / sdk: ❌

It'll stay between us, no one needs to know.

@guilhem-barthes guilhem-barthes mentioned this pull request Mar 4, 2024
Merged
2 tasks
@guilhem-barthes
Copy link
Contributor Author

/e2e --refs=orchestrator=feat/update-computeplan-status,substra-backend=feat/update-computeplan-status,substra=feat/update-computeplan-status,substra-frontend=feat/update-computeplan-status --tests=doc,camelyon,mnist,substrafl,sdk

@Owlfred
Copy link

Owlfred commented Mar 4, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

  • Camelyon / camelyon: ❌
  • Dispatch Jobs: ✔️
  • Documentation / doc: ❌
  • Frontend: ⏭️
  • MNIST / mnist: ❌
  • SubstraFL / substrafl: ❌
  • SubstraSDK / sdk: ❌

“Success is not final; failure is not fatal: It is the courage to continue that counts.” ―- Winston S. Churchill

@guilhem-barthes
chore: rename ComputeTask DOING to EXECUTING
e1636c5 
Signed-off-by: Guilhem Barthés <[email protected]>
@guilhem-barthes
docs: changelog
39a9fa1 
Signed-off-by: Guilhem Barthés <[email protected]>
@guilhem-barthes guilhem-barthes force-pushed the feat/update-computeplan-status branch from 22a10e1 to 39a9fa1 Compare March 4, 2024 14:32
@guilhem-barthes
Copy link
Contributor Author

/e2e --refs=orchestrator=feat/update-computeplan-status,substra-backend=feat/update-computeplan-status,substra=feat/update-computeplan-status,substra-frontend=feat/update-computeplan-status --tests=doc,camelyon,mnist,substrafl,sdk

@Owlfred
Copy link

Owlfred commented Mar 4, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

Better luck next time!

@guilhem-barthes
Copy link
Contributor Author

/e2e --tests=substrafl

@Owlfred
Copy link

Owlfred commented Mar 4, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

You rock!

@guilhem-barthes guilhem-barthes merged commit c4fc92b into main Mar 5, 2024
2 of 6 checks passed
@guilhem-barthes guilhem-barthes deleted the feat/update-computeplan-status branch March 5, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThibaultFy ThibaultFy ThibaultFy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guilhem-barthes @Owlfred @ThibaultFy