-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump Pytorch version to 2.2.1 in tests #369
Conversation
Signed-off-by: SdgJlbl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! How can we make sure we spot this earlier next time?
I'm actually not sure 🤔 The end-to-end tests were running fine, so I'm not sure... I guess that the matrices used are not exactly the same between the nightly and the manually triggered end-to-end tests, might be worth looking into it more deeply. |
Yes indeed, I think the local tests are actually never triggered except in the nightly. Can you create a follow-up task so we can look at it later? Thank you! |
/e2e --tests=sdk |
/e2e --tests=sdk |
End to end tests: ✔️ SUCCESS |
Fixes CI following Python 3.12 support.