Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump Pytorch version to 2.2.1 in tests #369

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

SdgJlbl
Copy link
Contributor

@SdgJlbl SdgJlbl commented Jul 25, 2024

Fixes CI following Python 3.12 support.

@SdgJlbl SdgJlbl requested a review from a team as a code owner July 25, 2024 07:52
Copy link
Contributor

@thbcmlowk thbcmlowk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! How can we make sure we spot this earlier next time?

@SdgJlbl
Copy link
Contributor Author

SdgJlbl commented Jul 25, 2024

Thanks for fixing this! How can we make sure we spot this earlier next time?

I'm actually not sure 🤔

The end-to-end tests were running fine, so I'm not sure... I guess that the matrices used are not exactly the same between the nightly and the manually triggered end-to-end tests, might be worth looking into it more deeply.

@thbcmlowk
Copy link
Contributor

Thanks for fixing this! How can we make sure we spot this earlier next time?

I'm actually not sure 🤔

The end-to-end tests were running fine, so I'm not sure... I guess that the matrices used are not exactly the same between the nightly and the manually triggered end-to-end tests, might be worth looking into it more deeply.

Yes indeed, I think the local tests are actually never triggered except in the nightly. Can you create a follow-up task so we can look at it later? Thank you!

@SdgJlbl SdgJlbl merged commit 59e9527 into main Jul 25, 2024
5 checks passed
@SdgJlbl SdgJlbl deleted the chore/bump-torch branch July 25, 2024 08:26
@thbcmlowk
Copy link
Contributor

/e2e --tests=sdk

@Owlfred
Copy link

Owlfred commented Jul 26, 2024

End to end tests: ❌ FAILURE

Jobs status:

“Rien ne sert de courir ; il faut partir à point.” ― Jean de La Fontaine (Le Lièvre et la Tortue)

@thbcmlowk thbcmlowk restored the chore/bump-torch branch July 26, 2024 10:28
@thbcmlowk
Copy link
Contributor

/e2e --tests=sdk

@Owlfred
Copy link

Owlfred commented Jul 26, 2024

End to end tests: ✔️ SUCCESS

@SdgJlbl SdgJlbl deleted the chore/bump-torch branch October 1, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants