Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add test for function build cancelation #383

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

guilhem-barthes
Copy link
Contributor

@guilhem-barthes guilhem-barthes commented Sep 9, 2024

Copy link

linear bot commented Sep 9, 2024

@guilhem-barthes guilhem-barthes marked this pull request as ready for review September 10, 2024 09:42
@guilhem-barthes guilhem-barthes requested a review from a team as a code owner September 10, 2024 09:42
Signed-off-by: Guilhem Barthés <[email protected]>
Copy link
Contributor

@SdgJlbl SdgJlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work, I think we are missing some status check on one of the two functions though.

tests/test_docker_image_build.py Outdated Show resolved Hide resolved
tests/test_docker_image_build.py Outdated Show resolved Hide resolved
@guilhem-barthes guilhem-barthes merged commit 329cac2 into main Sep 30, 2024
5 checks passed
@guilhem-barthes guilhem-barthes deleted the feat/check-computeplans-before-running-function branch September 30, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants