Skip to content

Commit

Permalink
chore: rebase legacy
Browse files Browse the repository at this point in the history
Signed-off-by: ThibaultFy <[email protected]>
  • Loading branch information
ThibaultFy committed Feb 27, 2024
1 parent 3490eee commit be54e97
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 12 deletions.
2 changes: 1 addition & 1 deletion substrafl/evaluation_strategy.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def __init__(
raise ValueError("test_data_nodes lists cannot be empty")

if not all(isinstance(node, TestDataNodeProtocol) for node in test_data_nodes):
raise TypeError("test_data_nodes must respect the TestDataNodeProtocol")
raise TypeError("test_data_nodes must implement the TestDataNodeProtocol")

if eval_frequency is None and eval_rounds is None:
raise ValueError("At least one of eval_frequency or eval_rounds must be defined")
Expand Down
4 changes: 0 additions & 4 deletions substrafl/strategies/scaffold.py
Original file line number Diff line number Diff line change
Expand Up @@ -158,11 +158,7 @@ def perform_evaluation(

test_data_node.update_states(
operation=self.evaluate(
<<<<<<< HEAD
data_samples=test_data_node.data_sample_keys,
=======
data_samples=test_data_node.test_data_sample_keys,
>>>>>>> a79ee49 (rebase)
_algo_name=f"Evaluating with {self.__class__.__name__}",
),
traintask_id=local_state.key,
Expand Down
7 changes: 0 additions & 7 deletions substrafl/strategies/strategy.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,10 @@
from substrafl.algorithms.algo import Algo
from substrafl.compute_plan_builder import ComputePlanBuilder
from substrafl.evaluation_strategy import EvaluationStrategy
<<<<<<< HEAD
from substrafl.nodes import AggregationNodeProtocol
from substrafl.nodes import TestDataNodeProtocol
from substrafl.nodes import TrainDataNodeProtocol
from substrafl.nodes.schemas import OutputIdentifiers
=======
from substrafl.nodes.aggregation_node import AggregationNode
from substrafl.nodes.node import OutputIdentifiers
from substrafl.nodes.test_data_node import TestDataNode
from substrafl.nodes.train_data_node import TrainDataNode
>>>>>>> a79ee49 (rebase)
from substrafl.remote.decorators import remote_data
from substrafl.strategies.schemas import StrategyName

Expand Down

0 comments on commit be54e97

Please sign in to comment.