Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove substrafl wheel cache #175

Merged
merged 1 commit into from
Oct 10, 2023
Merged

feat: remove substrafl wheel cache #175

merged 1 commit into from
Oct 10, 2023

Conversation

SdgJlbl
Copy link
Contributor

@SdgJlbl SdgJlbl commented Oct 4, 2023

Related issue

Fixes FL-1166

Summary

Notes

Please check if the PR fulfills these requirements

  • If the feature has an impact on the user experience, the changelog has been updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The commit message follows the conventional commit specification

@linear
Copy link

linear bot commented Oct 4, 2023

FL-1166 Remove SubstraFL wheel cache

Context

cf https://github.com/Substra/substrafl/pull/155/files#r1281654779

It's error-prone (because the cache is never invalidated), and not really a performance boost. It should go.

Specification

Acceptance criteria

@Substra Substra deleted a comment from Owlfred Oct 4, 2023
@SdgJlbl
Copy link
Contributor Author

SdgJlbl commented Oct 4, 2023

/e2e

@Owlfred
Copy link

Owlfred commented Oct 4, 2023 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

That's a shame.

@SdgJlbl SdgJlbl marked this pull request as ready for review October 4, 2023 14:09
@SdgJlbl SdgJlbl requested a review from a team as a code owner October 4, 2023 14:09
@ThibaultFy
Copy link
Member

/e2e --tests substrafl --benchmarks camelyon

@Owlfred
Copy link

Owlfred commented Oct 4, 2023 •
edited
Loading

End to end tests: ✔️ SUCCESS

Yay! 🎉

ThibaultFy
ThibaultFy reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR ! just waiting for the e2e tests to run :)

CHANGELOG.md Outdated Show resolved Hide resolved
substrafl/dependency/manage_dependencies.py Outdated Show resolved Hide resolved
ThibaultFy
ThibaultFy approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI ✅

@SdgJlbl
Copy link
Contributor Author

SdgJlbl commented Oct 9, 2023

/e2e --tests substrafl --benchmarks camelyon

@Owlfred
Copy link

Owlfred commented Oct 9, 2023 •
edited
Loading

End to end tests: ✔️ SUCCESS

@thbcmlowk
Copy link
Contributor

/e2e --tests=substrafl,mnist,camelyon

@Owlfred
Copy link

Owlfred commented Oct 10, 2023 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

That's a shame.

@thbcmlowk
Copy link
Contributor

/e2e --tests=mnist

@Owlfred
Copy link

Owlfred commented Oct 10, 2023 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

“Boy, that escalated quickly.” ― Ron Burgundy, Anchorman: The Legend of Ron Burgundy

@thbcmlowk
Copy link
Contributor

/e2e --tests=mnist '--refs=substra-backend=0.42.1'

@Owlfred
Copy link

Owlfred commented Oct 10, 2023 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

Oh noes.

@Substra Substra deleted a comment from Owlfred Oct 10, 2023
@thbcmlowk
Copy link
Contributor

/e2e --help

@Owlfred
Copy link

Owlfred commented Oct 10, 2023 

Usage: /e2e [options] [help]

/e2e may appear anywhere as long as it is on its own line

Options:
  --refs <value>                                         Extra refs (branch or tag) with format REPO=GIT_REF,REPO=GIT_REF.
  Supported repositories: hlf-k8s, orchestrator, substra-backend, substra-frontend, substra-tools, substrafl, substra, substra-tests, substra-documentation, substra-ci.
  Example: /e2e --refs substra-backend=some_branch,orchestrator=some_tag (default: {})
  --tests-to-run, --tests <tests-to-run>                 Comma-separated list of tests to run. Valid options: sdk,substrafl,doc,frontend or NONE. (default: "sdk")
  --benchmarks-to-run, --benchmarks <benchmarks-to-run>  Comma-separated list of workflows tests to run. Valid options: mnist, camelyon or NONE. (default: "NONE")
  --orchestrator-mode, --mode <orchestrator-mode>        Comma-separated list of orchestrator modes to run tests for. Valid options: standalone,distributed (default: "standalone,distributed")
  -h, --help                                             display help for command

@thbcmlowk
Copy link
Contributor

/e2e --tests mnist --refs substra-backend=0.42.1

@Owlfred
Copy link

Owlfred commented Oct 10, 2023 •
edited
Loading

End to end tests: ✔️ SUCCESS

“I love it when a plan comes together.” ― Colonel John “Hannibal” Smith, The A-Team

@SdgJlbl SdgJlbl merged commit c9b52b3 into main Oct 10, 2023
7 checks passed
@SdgJlbl SdgJlbl deleted the feat/drop-cache branch October 10, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThibaultFy ThibaultFy ThibaultFy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SdgJlbl @Owlfred @ThibaultFy @thbcmlowk