-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove warnings from pydantic v2 #183
Conversation
FL-1241 Deprecated `dict` method in Pydantic
ContextRunning documentation example MNIST Cyclic raised the following warning:
SpecificationRemove usages of Acceptance criteriaRunning MNIST Cyclic does not raise the deprecation warning anymore |
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
cb14a75
to
499650d
Compare
Signed-off-by: ThibaultFy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/e2e -h |
|
I saw more substrafl/dependency/schemas.py:86
/usr/src/app/substrafl/substrafl/dependency/schemas.py:86: PydanticDeprecatedSince20: Pydantic V1 style `@validator` validators are deprecated. You should migrate to Pydantic V2 style `@field_validator` validators, see the migration guide for more details. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.4/migration/
@validator("local_installable_dependencies", "local_code") /usr/local/lib/python3.11/site-packages/pydantic/_internal/_config.py:267: PydanticDeprecatedSince20: Support for class-based `config` is deprecated, use ConfigDict instead. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.4/migration/
warnings.warn(DEPRECATION_MESSAGE, DeprecationWarning) It might be [quote] << worth >> [unquote] fixing them in this PR. WDYT? |
Yep I tried to fix them too. It's linked to the fact we are overwritting the |
No worries, not that big of deal. It was just in case it was an easy fix. Thanks for looking at it in the first place! |
Signed-off-by: ThibaultFy <[email protected]>
Related issue
closes FL-1241